Summary: | suggestion.suggesteddate should be set to NOW if not defined | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Kyle M Hall (khall) <kyle> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, kyle, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 11391 | ||
Bug Blocks: | |||
Attachments: |
Bug 13012 - suggestion.suggesteddate should be set to NOW if not defined
Bug 13012 - suggestion.suggesteddate should be set to NOW if not defined Bug 13012 - suggestion.suggesteddate should be set to NOW if not defined Bug 13012: Add more tests |
Description
Jonathan Druart
2014-09-30 10:47:10 UTC
Which is not possible. We should make this field a timestamp instead of a date. Created attachment 65127 [details] [review] Bug 13012 - suggestion.suggesteddate should be set to NOW if not defined Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Suggestions.t Created attachment 65139 [details] [review] Bug 13012 - suggestion.suggesteddate should be set to NOW if not defined Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Suggestions.t Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 65845 [details] [review] Bug 13012 - suggestion.suggesteddate should be set to NOW if not defined Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Suggestions.t Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 65846 [details] [review] Bug 13012: Add more tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.05. These patches have been pushed to 16.11.x and will be in 16.11.13. |