| Summary: | Login page image replacement technique fails when browser width exceeds 2000 pixels | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | cbrannon, chris, mtj, tomascohen |
| Version: | 3.16 | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
koha h1
Bug 13017 - Login page image replacement technique fails when browser width exceeds 2000 pixels [SIGNED OFF] Bug 13017 - Login page image replacement technique fails when browser width exceeds 2000 pixels [PASSED QA] Bug 13017 - Login page image replacement technique fails when browser width exceeds 2000 pixels |
||
|
Description
Nicole C. Engard
2014-09-30 20:30:11 UTC
‘Doctor, doctor, it hurts when I do this.’ ‘Then don’t do that!’ Sorry, I couldn't resist. Yes it's true. If your browser window goes much wider than 2000 pixels the image replacement technique which displays the Koha logo will fail, having this style: text-indent: -1000px; ...which at the time of implementation was expected to be PLENTY of space to exclude the possibility that someone's browser would be wide enough that the text would be visible. It may be that we need to increase that number, or it may be that there is a more modern image replacement technique which we should switch to. Created attachment 33462 [details] [review] Bug 13017 - Login page image replacement technique fails when browser width exceeds 2000 pixels This patch updates the image replacement technique used for Koha's login page. The old technique used a negative text-indent value to move the text offscreen, but that begins to fail more and more often as screens get larger. The new technqiue is described here: http://www.zeldman.com/2012/03/01/replacing-the-9999px-hack-new-image-replacement/ Note: This patch has not been tested in any Internet Explorer version! To test you must have a screen which is wider than 2000 pixels. Apply the patch, clear your browser cache and view the staff client login page. The logo on the login form should look correct with no corresponding text appearing anywhere on the screen. (In reply to Owen Leonard from comment #2) > Note: This patch has not been tested in any Internet Explorer version! Works in IE 11. Created attachment 34045 [details] [review] [SIGNED OFF] Bug 13017 - Login page image replacement technique fails when browser width exceeds 2000 pixels This patch updates the image replacement technique used for Koha's login page. The old technique used a negative text-indent value to move the text offscreen, but that begins to fail more and more often as screens get larger. The new technqiue is described here: http://www.zeldman.com/2012/03/01/replacing-the-9999px-hack-new-image-replacement/ Note: This patch has not been tested in any Internet Explorer version! To test you must have a screen which is wider than 2000 pixels. Apply the patch, clear your browser cache and view the staff client login page. The logo on the login form should look correct with no corresponding text appearing anywhere on the screen. Signed-off-by: Christopher Brannon <cbrannon@debian.localdomain> Created attachment 34156 [details] [review] [PASSED QA] Bug 13017 - Login page image replacement technique fails when browser width exceeds 2000 pixels This patch updates the image replacement technique used for Koha's login page. The old technique used a negative text-indent value to move the text offscreen, but that begins to fail more and more often as screens get larger. The new technqiue is described here: http://www.zeldman.com/2012/03/01/replacing-the-9999px-hack-new-image-replacement/ Note: This patch has not been tested in any Internet Explorer version! To test you must have a screen which is wider than 2000 pixels. Apply the patch, clear your browser cache and view the staff client login page. The logo on the login form should look correct with no corresponding text appearing anywhere on the screen. Signed-off-by: Christopher Brannon <cbrannon@debian.localdomain> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch pushed to master. Thanks Owen! Pushed to 3.18.x will be in 3.18.3 Pushed to 3.16.x, patch will be in 3.16.7 |