Summary: | Vendor search: sorting of "item count" and "biblio count" columns can be incorrect | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 13039 - Vendor search: sorting of "item count" and "biblio count" columns can be incorrect
Bug 13039 - Vendor search: sorting of "item count" and "biblio count" columns can be incorrect [PASSED QA] Bug 13039 - Vendor search: sorting of "item count" and "biblio count" columns can be incorrect |
Description
Owen Leonard
2014-10-07 18:53:36 UTC
Created attachment 32058 [details] [review] Bug 13039 - Vendor search: sorting of "item count" and "biblio count" columns can be incorrect On the vendor search results page if some cells contain textual data the "item count" and "biblio count" columns will sort incorrectly. This patch sets an explicit numeric sort on these columns. In doing so this patch also changes the existing column sorting configuration to use table header cell classes instead of sorting based on index. This patch also corrects two instances of unescaped ampersands. To test, search for a vendor which has multiple baskets, at least one of which should contain canceled orders. Confirm that sorting by item count, biblio count, date, and closed all work correctly. Created attachment 32299 [details] [review] Bug 13039 - Vendor search: sorting of "item count" and "biblio count" columns can be incorrect On the vendor search results page if some cells contain textual data the "item count" and "biblio count" columns will sort incorrectly. This patch sets an explicit numeric sort on these columns. In doing so this patch also changes the existing column sorting configuration to use table header cell classes instead of sorting based on index. This patch also corrects two instances of unescaped ampersands. To test, search for a vendor which has multiple baskets, at least one of which should contain canceled orders. Confirm that sorting by item count, biblio count, date, and closed all work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 32329 [details] [review] [PASSED QA] Bug 13039 - Vendor search: sorting of "item count" and "biblio count" columns can be incorrect On the vendor search results page if some cells contain textual data the "item count" and "biblio count" columns will sort incorrectly. This patch sets an explicit numeric sort on these columns. In doing so this patch also changes the existing column sorting configuration to use table header cell classes instead of sorting based on index. This patch also corrects two instances of unescaped ampersands. To test, search for a vendor which has multiple baskets, at least one of which should contain canceled orders. Confirm that sorting by item count, biblio count, date, and closed all work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> I have not been able to see the sorting problem, but the patch causes no regression and everything seems to work nicely. Passes QA script and tests. http://bugs.koha-community.org/show_bug.cgi?id=12039 Patch pushed to master. Thanks Owen! |