Bug 13050

Summary: Follow-up for bug 12371 on self-registration verification notice
Product: Koha Reporter: Marcel de Rooy <m.de.rooy>
Component: OPACAssignee: Marcel de Rooy <m.de.rooy>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: tomascohen
Version: Main   
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12371
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 13050: Follow-up for bug 12371
Bug 13050: Follow-up for bug 12371
[PASSED QA] Bug 13050: Follow-up for bug 12371

Description Marcel de Rooy 2014-10-09 11:19:59 UTC

    
Comment 1 Marcel de Rooy 2014-10-09 11:23:26 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-10-26 02:06:12 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-10-26 10:56:43 UTC
Created attachment 32772 [details] [review]
[PASSED QA] Bug 13050: Follow-up for bug 12371

This patch simplifies the SQL query in Letters.pm for table
borrower_modifications.
It also addresses the only case this query is used in opac-memberentry.
An unused variable in Letters.pm is removed.

Test plan:
Enable selfregistration on opac.
Set verification by email to required in prefs too.
Self-register two new users.
Check the email notices generated.
Verify the new users with the tokens in their notice.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Much cleaner SQL

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Cleaner and works as described, no regressions found.
Passes tests and QA script.
Comment 4 Tomás Cohen Arazi 2014-11-21 18:35:49 UTC
Patch pushed to master.

Thanks Marcel!