|
Description
Owen Leonard
2014-10-10 16:41:09 UTC
Created attachment 32183 [details] [review] Bug 13069 - Enable sort by title to ignore articles on circulation and patron detail pages With the conversion of the circulation and patron detail checkout summary tables to AJAX recently we lost the ability to sort by title while ignoring articles. This patch corrects the problem by adding the "anti-the" configuration to the relevant column in the DataTables initializtion script. To test, apply the patch and clear your cache if necessary. Check out to a patron who has multiple checkouts, some of which have titles beginning with "a," "an," and "the." Sorting those checkouts by title should ignore articles. Test the patron detail page for that patron as well. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 32237 [details] [review] Bug 13069 - Enable sort by title to ignore articles on circulation and patron detail pages With the conversion of the circulation and patron detail checkout summary tables to AJAX recently we lost the ability to sort by title while ignoring articles. This patch corrects the problem by adding the "anti-the" configuration to the relevant column in the DataTables initializtion script. To test, apply the patch and clear your cache if necessary. Check out to a patron who has multiple checkouts, some of which have titles beginning with "a," "an," and "the." Sorting those checkouts by title should ignore articles. Test the patron detail page for that patron as well. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 32238 [details] [review] Bug 13069 - (follow-up) Enable sort by title to ignore articles This should affect the relatives' checkouts table too. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Guys, can you ammend both patches so they apply? They seem trivial but I need to focus on other patches right now for string freeze. Wrong option chosen :-P Created attachment 37395 [details] [review] Bug 13069 - Enable sort by title to ignore articles on circulation and patron detail pages With the conversion of the circulation and patron detail checkout summary tables to AJAX recently we lost the ability to sort by title while ignoring articles. This patch corrects the problem by adding the "anti-the" configuration to the relevant column in the DataTables initializtion script. To test, apply the patch and clear your cache if necessary. Check out to a patron who has multiple checkouts, some of which have titles beginning with "a," "an," and "the." Sorting those checkouts by title should ignore articles. Test the patron detail page for that patron as well. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> NOTE: This is the one early in the javascript file. This is the one visible by having multiple checkouts where the title excluding the articles is a different order than titles including the articles. Patrons -> Details (scroll down to check out area, view checkouts and toggle the title sort) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 37396 [details] [review] Bug 13069 - (follow-up) Enable sort by title to ignore articles This should affect the relatives' checkouts table too. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> NOTE: This is the one later in the javascript file. Checkout tab on the patron details page. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> I'm not sure if this should be back to Passed QA or what, but since I fixed it and signed it off. I'll let someone else figure out what's next. Created attachment 37479 [details] [review] [PASSED QA] Bug 13069 - Enable sort by title to ignore articles on circulation and patron detail pages With the conversion of the circulation and patron detail checkout summary tables to AJAX recently we lost the ability to sort by title while ignoring articles. This patch corrects the problem by adding the "anti-the" configuration to the relevant column in the DataTables initializtion script. To test, apply the patch and clear your cache if necessary. Check out to a patron who has multiple checkouts, some of which have titles beginning with "a," "an," and "the." Sorting those checkouts by title should ignore articles. Test the patron detail page for that patron as well. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> NOTE: This is the one early in the javascript file. This is the one visible by having multiple checkouts where the title excluding the articles is a different order than titles including the articles. Patrons -> Details (scroll down to check out area, view checkouts and toggle the title sort) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 37480 [details] [review] [PASSED QA] Bug 13069 - (follow-up) Enable sort by title to ignore articles This should affect the relatives' checkouts table too. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> NOTE: This is the one later in the javascript file. Checkout tab on the patron details page. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patches pushed to master. Thanks Martin! Pushed to 3.18.x will be in 3.18.6 |