Description
Tomás Cohen Arazi (tcohen)
2014-10-15 16:09:18 UTC
Created attachment 32553 [details] [review] Bug 13088: Add a syspref so the user can chose the amount of facets to show This patch introduces a syspref (FacetMaxCount) that controls how many facets to show for each category (e.g. Author). Sponsored-by: Universidad Nacional de Cordoba Created attachment 32554 [details] [review] Bug 13088: Allow the user to specify a max amount of facets to show This patch makes _get_facet_from_result_set rely on a new syspref (FacetsMaxCount) to set the max facets to show for each facet category. It defaults to 20 if the syspref is absent or empty. To test: - Have a search with lots of facet results (with some category showing the "See more" link). - Jump to "See more", notice it shows more than 20 facet values. - Apply the patch, reload the page. => SUCCESS It only shows 20 (default hardcoded value) - Change the FacetsMaxCount syspref to other value (e.g. 15 or 100). - Reload => SUCCESS: it shows the expected amount. - Sign off :-D Regards Sponsored-by: Universidad Nacional de Cordoba Created attachment 32667 [details] [review] [SIGNED-OFF] Bug 13088: Add a syspref so the user can chose the amount of facets to show This patch introduces a syspref (FacetMaxCount) that controls how many facets to show for each category (e.g. Author). Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 32668 [details] [review] [SIGNED-OFF] Bug 13088: Allow the user to specify a max amount of facets to show This patch makes _get_facet_from_result_set rely on a new syspref (FacetsMaxCount) to set the max facets to show for each facet category. It defaults to 20 if the syspref is absent or empty. To test: - Have a search with lots of facet results (with some category showing the "See more" link). - Jump to "See more", notice it shows more than 20 facet values. - Apply the patch, reload the page. => SUCCESS It only shows 20 (default hardcoded value) - Change the FacetsMaxCount syspref to other value (e.g. 15 or 100). - Reload => SUCCESS: it shows the expected amount. - Sign off :-D Regards Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> Test plan completed successfully Created attachment 32738 [details] [review] [PASSED QA] Bug 13088: Add a syspref so the user can chose the amount of facets to show This patch introduces a syspref (FacetMaxCount) that controls how many facets to show for each category (e.g. Author). Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 32739 [details] [review] [PASSED QA] Bug 13088: Allow the user to specify a max amount of facets to show This patch makes _get_facet_from_result_set rely on a new syspref (FacetsMaxCount) to set the max facets to show for each facet category. It defaults to 20 if the syspref is absent or empty. To test: - Have a search with lots of facet results (with some category showing the "See more" link). - Jump to "See more", notice it shows more than 20 facet values. - Apply the patch, reload the page. => SUCCESS It only shows 20 (default hardcoded value) - Change the FacetsMaxCount syspref to other value (e.g. 15 or 100). - Reload => SUCCESS: it shows the expected amount. - Sign off :-D Regards Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> Test plan completed successfully Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Passes tests and QA script, works as described. Patch pushed to master. Created attachment 32844 [details] [review] Bug 13088: (RM followup) add missing pref mock Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> |