Bug 13097

Summary: Use of ampersands ( & ) in holiday titles or descriptions breaks the calendar
Product: Koha Reporter: Kyle M Hall <kyle>
Component: ToolsAssignee: Galen Charlton <gmcharlt>
Status: CLOSED INVALID QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: jonathan.druart, joonas.kylmala, kyle.m.hall, kyle, magnus
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Demonstration Video

Description Kyle M Hall 2014-10-16 14:01:03 UTC
Use of ampersands ( & ) in holiday titles or descriptions breaks the calendar. At that point, the only way to recover is to edit the database directly and remove the offending characters.

See video for demonstration.
Comment 1 Kyle M Hall 2014-10-16 14:01:29 UTC
Created attachment 32414 [details]
Demonstration Video
Comment 2 Magnus Enger 2014-11-26 13:36:50 UTC
I can't seem to reproduce this on current master. I added a one-off holiday with an ampersand in the title as well as a weekly holiday with an ampersand in the title, and the calendar still displays fine. I did find a very similar problem over on bug 11211, though.
Comment 3 Magnus Enger 2014-11-26 14:05:35 UTC
Could it be that the ampersand is not the real problem here, but that the holiday is repeated weekly? Or in other words: is this a duplicate of bug 13289? 

Kyle: Can you reproduce for a holiday that is not repeated weekly?
Comment 4 Jonathan Druart 2015-07-15 10:01:39 UTC
Kyle, ping? :)
Comment 5 Joonas Kylmälä 2015-08-21 09:54:49 UTC
On current master I wasn't able to reproduce this bug anymore. I tried  ampersands in the title/description with:  
 - every  Holiday only on this day.
 - Holiday repeated every same day of the week.
 - Holiday repeated yearly on the same date

Can we close this bug?
Comment 6 Kyle M Hall 2015-08-21 10:14:58 UTC
Agreed. I have been unable to reproduce on master as well.

(In reply to Joonas Kylmälä from comment #5)
> On current master I wasn't able to reproduce this bug anymore. I tried 
> ampersands in the title/description with:  
>  - every  Holiday only on this day.
>  - Holiday repeated every same day of the week.
>  - Holiday repeated yearly on the same date
> 
> Can we close this bug?