| Summary: | Serial failure for received and general viewing | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Aliza <librarian> |
| Component: | Serials | Assignee: | Mason James <mtj> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P3 | CC: | chris, colin.campbell, danielle, jonathan.druart, mtj, mtompset, rolando.isidoro, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 14036 | ||
| Attachments: |
Bug 13109 - Serial failure for received and general viewing.
Bug 13109 - Serial failure for received and general viewing. Bug 13109 - Serial failure for received and general viewing. [PASSED QA] Bug 13109 - Serial failure for received and general viewing. |
||
|
Description
Aliza
2014-10-17 17:07:48 UTC
(In reply to Aliza from comment #0) > For Log Magazine, also still an issue for Sports Business Journal > > Received the following message > > Software error: > > Usage: Date::Calc::Delta_Days(year1, month1, day1, year2, month2, day2) at > /usr/share/koha/lib/C4/Serials.pm line 2379. > For help, please send mail to the webmaster (staff@bywatersolutions.com), > giving this error message and the time and date of the error. hmm, we just hit this bug on 3.16.7 i'll do a little more digging on this one (In reply to Aliza from comment #0) > For Log Magazine, also still an issue for Sports Business Journal > > Received the following message > > Software error: > > Usage: Date::Calc::Delta_Days(year1, month1, day1, year2, month2, day2) at > /usr/share/koha/lib/C4/Serials.pm line 2379. > For help, please send mail to the webmaster (staff@bywatersolutions.com), > giving this error message and the time and date of the error. aah, i see the problem here... the abouttoexpire() sub tries to compare 2 dates, but doesnt check that both dates actually exist i'll send a patch for this Created attachment 37356 [details] [review] Bug 13109 - Serial failure for received and general viewing. modified: C4/Serials.pm Created attachment 37357 [details] [review] Bug 13109 - Serial failure for received and general viewing. to test... 1/ attempt to view a subscription-detail that has a NULL value for either it's 'startdate' or 'enddate' an example url would be... http://koha-admin.foo.org/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=1 observe error... 'Date::Calc::PP::Delta_Days(): Usage: Date::Calc::Delta_Days($year1,$month1,$day1,$year2,$month2,$day2) at /your/koha/C4/Serials.pm line 2325' 2/ apply patch 3/ repeat step 1/ observe that detail page displays OK ..bug confirmed on master, and 3.18.5 too (In reply to Mason James from comment #4) > 1/ attempt to view a subscription-detail that has a NULL value for either > it's 'startdate' or 'enddate' The date picker forces it or a length to be entered. How do you get this situation without messing with data in the back end? > an example url would be... > > http://koha-admin.foo.org/cgi-bin/koha/serials/subscription-detail. > pl?subscriptionid=1 > > observe error... > 'Date::Calc::PP::Delta_Days(): Usage: > Date::Calc::Delta_Days($year1,$month1,$day1,$year2,$month2,$day2) at > /your/koha/C4/Serials.pm line 2325' > > 2/ apply patch > 3/ repeat step 1/ > observe that detail page displays OK Could you just confirm test steps more explicitly, assuming fresh install with one superlibrarian created and defaults all installed? Created attachment 37716 [details] [review] Bug 13109 - Serial failure for received and general viewing. to test... 1/ attempt to view a subscription-detail that has a NULL value for either it's 'startdate' or 'enddate' an example url would be... http://koha-admin.foo.org/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=1 observe error... 'Date::Calc::PP::Delta_Days(): Usage: Date::Calc::Delta_Days($year1,$month1,$day1,$year2,$month2,$day2) at /your/koha/C4/Serials.pm line 2325' 2/ apply patch 3/ repeat step 1/ observe that detail page displays OK Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> I confirm the issue if startdate is null (can exist with old data, before the js check on the form). Amended patch: Remove trailing space char and the link to the bz number (can be found using git log). (In reply to M. Tompsett from comment #6) > (In reply to Mason James from comment #4) > > 1/ attempt to view a subscription-detail that has a NULL value for either > > it's 'startdate' or 'enddate' > > The date picker forces it or a length to be entered. How do you get this > situation without messing with data in the back end? hmm, i'm really not sure but, we hit this bug in a prod koha, with no messing of data Created attachment 37915 [details] [review] [PASSED QA] Bug 13109 - Serial failure for received and general viewing. to test... 1/ attempt to view a subscription-detail that has a NULL value for either it's 'startdate' or 'enddate' an example url would be... http://koha-admin.foo.org/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=1 observe error... 'Date::Calc::PP::Delta_Days(): Usage: Date::Calc::Delta_Days($year1,$month1,$day1,$year2,$month2,$day2) at /your/koha/C4/Serials.pm line 2325' 2/ apply patch 3/ repeat step 1/ observe that detail page displays OK Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> I confirm the issue if startdate is null (can exist with old data, before the js check on the form). Amended patch: Remove trailing space char and the link to the bz number (can be found using git log). Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> *** Bug 14036 has been marked as a duplicate of this bug. *** (In reply to M. Tompsett from comment #10) > *** Bug 14036 has been marked as a duplicate of this bug. *** Correction, it isn't. :) Patch pushed to master. Thanks Mason! Pushed to 3.18.x will be in 3.18.7 Pushed to 3.16.x, will be in 3.16.11 (In reply to Mason James from comment #14) > Pushed to 3.16.x, will be in 3.16.11 I just wanted to say THANK YOU for adding the version that this is pushed to in the post! So helpful. |