Summary: | Move search results "action" links ("Place hold," "Add tag," etc) into include file | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | 1joynelson, david |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This patch moves markup for controls repeated across several OPAC templates into a single include (making it easier to maintain in the future): Place hold, Request article, Add tag, Save to lists, and Add to cart.
|
Version(s) released in: |
20.05.00
|
Circulation function: | |||
Bug Depends on: | 13083, 13119 | ||
Bug Blocks: | |||
Attachments: |
Bug 13121: Move search results "action" links ("Place hold," "Add tag," etc) into include file
Bug 13121: Move search results "action" links ("Place hold," "Add tag," etc) into include file Bug 13121: Move search results "action" links ("Place hold," "Add tag," etc) into include file |
Description
Owen Leonard
2014-10-21 17:14:21 UTC
There are three areas in the OPAC which display multiple rows of title information using XSLT. All three could use the same include file when displaying "action" links: "Place hold," "Add tags," etc. Created attachment 96891 [details] [review] Bug 13121: Move search results "action" links ("Place hold," "Add tag," etc) into include file This patch moves markup for controls repeated across several OPAC templates into a single include: Place hold, Request article, Add tag, Save to lists, and Add to cart. To test, apply the patch and view the following OPAC pages: - Search results - Shelf contents view - User tags list On each of these pages all the controls should work correctly: - Place hold - Request art - Add tag - Save to lists - Add to cart Created attachment 97803 [details] [review] Bug 13121: Move search results "action" links ("Place hold," "Add tag," etc) into include file This patch moves markup for controls repeated across several OPAC templates into a single include: Place hold, Request article, Add tag, Save to lists, and Add to cart. Enable ArticleRequests and TagsInputOnList system preferences. To test, apply the patch and view the following OPAC pages: - Search results - Shelf contents view - User tags list On each of these pages all the controls should work correctly: - Place hold - Request articles - Add tag - Save to lists - Add to cart Signed-off-by: David Nind <david@davidnind.com> I'm assuming 'Shelf contents view' is either the Cart or Lists - all the actions seem to work as expected in those areas. Hi Owen, can you please check this fail from the QA script? FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/title-actions-menu.inc OK filters FAIL forbidden patterns forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 32) (In reply to Katrin Fischer from comment #5) > forbidden pattern: Contains old bootstrap style for buttons (see bug It's a false positive. The OPAC still uses the "old bootstrap." The warning should only be triggered for staff client templates. (In reply to Owen Leonard from comment #6) > (In reply to Katrin Fischer from comment #5) > > forbidden pattern: Contains old bootstrap style for buttons (see bug > > It's a false positive. The OPAC still uses the "old bootstrap." The warning > should only be triggered for staff client templates. Thx! Hi Owen, I am passing this, but it looks like with and without this patch removing a title from the cart no longer works quite right. The (remove) link remains. Also: the cart message is hiding behind the floating toolbar for me. I filed bug 24521. Created attachment 98003 [details] [review] Bug 13121: Move search results "action" links ("Place hold," "Add tag," etc) into include file This patch moves markup for controls repeated across several OPAC templates into a single include: Place hold, Request article, Add tag, Save to lists, and Add to cart. To test, apply the patch and view the following OPAC pages: - Search results - Shelf contents view - User tags list On each of these pages all the controls should work correctly: - Place hold - Request art - Add tag - Save to lists - Add to cart Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work everyone! Pushed to master for 20.05 Enhancement not backported to 19.11.x |