Summary: | Duplicate label ids for language and opaclanguages | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | System Administration | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 13123 - Duplicate label ids for language and opaclanguages
Bug 13123 - Duplicate label ids for language and opaclanguages [PASSED QA] Bug 13123 - Duplicate label ids for language and opaclanguages |
Description
Owen Leonard
2014-10-21 18:18:48 UTC
Created attachment 32562 [details] [review] Bug 13123 - Duplicate label ids for language and opaclanguages When enabling or disabling a OPAC language choice clicking the label triggers the checkbox under the language preference instead. This is because both <label>s have the same id. This patch adds a modifier to each label and corresponding id attribute in order to make them unique. To test, go to Administration -> System preferences -> I18N/L10N. Clicking the "English (en)" label under the "language" system preference should toggle the corresponding checkbox. Clicking the "English (en)" label under the "opaclanguages" system preference should toggle the correct checkbox. Further tests: - Install an English 'sub-language' like en-GB and confirm that checkbox labels work correctly. - Install a non-English language and confirm that checkbox labels work correctly. Created attachment 32613 [details] [review] Bug 13123 - Duplicate label ids for language and opaclanguages When enabling or disabling a OPAC language choice clicking the label triggers the checkbox under the language preference instead. This is because both <label>s have the same id. This patch adds a modifier to each label and corresponding id attribute in order to make them unique. To test, go to Administration -> System preferences -> I18N/L10N. Clicking the "English (en)" label under the "language" system preference should toggle the corresponding checkbox. Clicking the "English (en)" label under the "opaclanguages" system preference should toggle the correct checkbox. Further tests: - Install an English 'sub-language' like en-GB and confirm that checkbox labels work correctly. - Install a non-English language and confirm that checkbox labels work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 32655 [details] [review] [PASSED QA] Bug 13123 - Duplicate label ids for language and opaclanguages When enabling or disabling a OPAC language choice clicking the label triggers the checkbox under the language preference instead. This is because both <label>s have the same id. This patch adds a modifier to each label and corresponding id attribute in order to make them unique. To test, go to Administration -> System preferences -> I18N/L10N. Clicking the "English (en)" label under the "language" system preference should toggle the corresponding checkbox. Clicking the "English (en)" label under the "opaclanguages" system preference should toggle the correct checkbox. Further tests: - Install an English 'sub-language' like en-GB and confirm that checkbox labels work correctly. - Install a non-English language and confirm that checkbox labels work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, template changes only. Patch pushed to master. Thanks Owen! |