Bug 13133

Summary:	Mangled UTF8 in pay.tt
Product:	Koha	Reporter:	paxed <pasi.kallinen>
Component:	Templates	Assignee:	Katrin Fischer <katrin.fischer>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	trivial
Priority:	P5 - low	CC:	martin.renvoize, tomascohen
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Bug 13133: Fix mangled titles on pay fines page Bug 13133: Fix mangled titles on pay fines page [Passed QA] Bug 13133: Fix mangled titles on pay fines page

Description paxed 2014-10-23 05:41:12 UTC

Go to patron info -> Fines -> Pay fines. If the patron has an accruing fine for a book, and the book title has utf8 characters, the "title" for that fine is mangled.

pay.tt uses "title | html_entity" which causes the mangling. boraccount.tt uses "title | html" which works correctly.

Comment 1 Katrin Fischer 2014-11-09 23:02:52 UTC Comment hidden (obsolete)

Created attachment 33401 [details] [review]
Bug 13133: Fix mangled titles on pay fines page

Titles with diacritics don't show correctly
on the 'pay fines' page in the patron account
in staff.

To test:
- Catalog or find a record with non-latin script
  Something like a word in Hebrew would work.
- Create a fine entry for that record
  Something like a rental fee works.
- Verify that the title doesn't display correct
  on the pay fine page (other tabs are ok)
- Apply patch
- Check the pages again - display should be
  correct now.

Comment 2 Chris Cormack 2014-11-10 05:40:12 UTC Comment hidden (obsolete)

Created attachment 33404 [details] [review]
Bug 13133: Fix mangled titles on pay fines page

Titles with diacritics don't show correctly
on the 'pay fines' page in the patron account
in staff.

To test:
- Catalog or find a record with non-latin script
  Something like a word in Hebrew would work.
- Create a fine entry for that record
  Something like a rental fee works.
- Verify that the title doesn't display correct
  on the pay fine page (other tabs are ok)
- Apply patch
- Check the pages again - display should be
  correct now.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Comment 3 Martin Renvoize (ashimema) 2014-11-12 08:05:32 UTC

Created attachment 33473 [details] [review]
[Passed QA] Bug 13133: Fix mangled titles on pay fines page

Titles with diacritics don't show correctly
on the 'pay fines' page in the patron account
in staff.

To test:
- Catalog or find a record with non-latin script
  Something like a word in Hebrew would work.
- Create a fine entry for that record
  Something like a rental fee works.
- Verify that the title doesn't display correct
  on the pay fine page (other tabs are ok)
- Apply patch
- Check the pages again - display should be
  correct now.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Comment 4 Martin Renvoize (ashimema) 2014-11-12 08:06:01 UTC

Super trivial, works as expected... passing qa.

Comment 5 Tomás Cohen Arazi (tcohen) 2014-11-21 23:52:35 UTC

Patch pushed to master.

Thanks Katrina!