|
Description
Kyle M Hall (khall)
2014-10-23 11:16:37 UTC
Created attachment 32617 [details] [review] Bug 13134 - Add patron category to returns confirmation dialogs Some librarians find it useful to know what category a patron is before confirming a reserve or transfer from the checkin screen. This patch adds the patron category to the hold and transfer popups to the patron information already displayed. The li tags that contain the patron category have the class "patron-category" to allow this data to be easily hidden. Test Plan: 1) Apply this patch 2) Trap a hold for a patron, note the patron category is now displayed 3) Trap a hold for pickup at another loation, note the patron category is now displayed Created attachment 32618 [details] [review] Bug 13134 - Add patron category to returns confirmation dialogs Some librarians find it useful to know what category a patron is before confirming a reserve or transfer from the checkin screen. This patch adds the patron category to the hold and transfer popups to the patron information already displayed. The li tags that contain the patron category have the class "patron-category" to allow this data to be easily hidden. Test Plan: 1) Apply this patch 2) Trap a hold for a patron, note the patron category is now displayed 3) Trap a hold for pickup at another loation, note the patron category is now displayed My inclination is to add this to the line with the patron name, similar to the way we do it on the screen where you submit a partial name for checkout and are presented with a multi-select. For example: <li> <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borsurname %], [% borfirstname %]</a> ([% borcnum %]<span class="patron-category"> - [% borcategory %]</span>) </li> Which would like something like this: - Leonard, Owen (012345 - Adult) Seems more compact and logical to me. (In reply to Owen Leonard from comment #3) > My inclination is to add this to the line with the patron name, similar to > the way we do it on the screen where you submit a partial name for checkout > and are presented with a multi-select. For example: > > <li> > <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% > borrowernumber %]">[% borsurname %], [% borfirstname %]</a> > ([% borcnum %]<span class="patron-category"> - [% borcategory %]</span>) > </li> > > Which would like something like this: > > - Leonard, Owen (012345 - Adult) > > Seems more compact and logical to me. I agree. I think that's a much better idea. I'll update the patch as soon as I can. Created attachment 32642 [details] [review] Bug 13134 - Add patron category to returns confirmation dialogs Some librarians find it useful to know what category a patron is before confirming a reserve or transfer from the checkin screen. This patch adds the patron category to the hold and transfer popups to the patron information already displayed. The li tags that contain the patron category have the class "patron-category" to allow this data to be easily hidden. Test Plan: 1) Apply this patch 2) Trap a hold for a patron, note the patron category is now displayed 3) Trap a hold for pickup at another loation, note the patron category is now displayed (In reply to Kyle M Hall from comment #5) > 2) Trap a hold for a patron, note the patron category is now displayed > 3) Trap a hold for pickup at another loation, note the patron category > is now displayed I think there's a copy-paste error. I'm not seeing the patron category in this latest version for either of those cases. Created attachment 54282 [details] [review] Bug 13134: Fix template file to make category appear This is a followup to rescue the bug. To test: Follow test plan from comment #1 Created attachment 54306 [details] [review] [SIGNED-OFF] Bug 13134 - Add patron category to returns confirmation dialogs Some librarians find it useful to know what category a patron is before confirming a reserve or transfer from the checkin screen. This patch adds the patron category to the hold and transfer popups to the patron information already displayed. The li tags that contain the patron category have the class "patron-category" to allow this data to be easily hidden. Test Plan: 1) Apply this patch 2) Trap a hold for a patron, note the patron category is now displayed 3) Trap a hold for pickup at another loation, note the patron category is now displayed Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 54307 [details] [review] [SIGNED-OFF] Bug 13134: Fix template file to make category appear This is a followup to rescue the bug. To test: Follow test plan from comment #1 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 54358 [details] [review] Bug 13134 - Add patron category to returns confirmation dialogs Some librarians find it useful to know what category a patron is before confirming a reserve or transfer from the checkin screen. This patch adds the patron category to the hold and transfer popups to the patron information already displayed. The li tags that contain the patron category have the class "patron-category" to allow this data to be easily hidden. Test Plan: 1) Apply this patch 2) Trap a hold for a patron, note the patron category is now displayed 3) Trap a hold for pickup at another loation, note the patron category is now displayed Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 54359 [details] [review] Bug 13134: Fix template file to make category appear This is a followup to rescue the bug. To test: Follow test plan from comment #1 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 16.11, thanks for the followup Marc! |