Summary: | Google transliteration does not work on bootstrap | ||
---|---|---|---|
Product: | Koha | Reporter: | Amit Gupta <amitddng135> |
Component: | OPAC | Assignee: | Amit Gupta <amitddng135> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | amitddng135, indradg, liz, mtompset, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 13211 | ||
Bug Blocks: | 13206 | ||
Attachments: |
Bug 13144 - Google transliteration does not work on bootstrap
Bug 13144: Google transliteration does not work on bootstrap [PASSED QA] Bug 13144: Google transliteration does not work on bootstrap Bug-13211: Added Google Indic Transliteration as a System Preference |
Description
Amit Gupta
2014-10-25 07:41:34 UTC
Created attachment 33202 [details] [review] Bug 13144 - Google transliteration does not work on bootstrap There was no id defined for that particular element to identify it. To Test: Use Google Indic Transliteration API to allow users to transliterate english typed words into Indic languages. Follow patch: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=6ae7b60962e7d07aa00a45a7af692939a4ce7aa6 Created attachment 33220 [details] [review] Bug 13144: Google transliteration does not work on bootstrap To Test: Use Google Indic Transliteration API to allow users to transliterate english typed words into Indic languages. http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=6ae7b60962e7d07aa00a45a7af692939a4ce7aa6 Signed-off-by: Frederic Demians <f.demians@tamil.fr> I had been able to reproduce the bug (a regression), and I can confirm that this patch fix it. But I had to create manualy GoogleIndicTransliteration system preference, which doesn't exist in standard .pref file. It may be necessary to add it. In my opinion, it shouldn't prevent to include this patch. I think this should not stay an undocumented feature. At least the preference should not have to be manually added but be a part of the sys pref editor. Created attachment 33272 [details] [review] [PASSED QA] Bug 13144: Google transliteration does not work on bootstrap To Test: Use Google Indic Transliteration API to allow users to transliterate english typed words into Indic languages. http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=6ae7b60962e7d07aa00a45a7af692939a4ce7aa6 Signed-off-by: Frederic Demians <f.demians@tamil.fr> I had been able to reproduce the bug (a regression), and I can confirm that this patch fix it. But I had to create manualy GoogleIndicTransliteration system preference, which doesn't exist in standard .pref file. It may be necessary to add it. In my opinion, it shouldn't prevent to include this patch. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixes a somewhat 'hidden' feature, no problems found. Hi Katrin, Thanks will create Google Transliteration as a system preference. Please see Bug: 13211 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211 Hi Katrin, I have created the patch Bug: 13211. Please test. Created attachment 33301 [details] [review] Bug-13211: Added Google Indic Transliteration as a System Preference Test scenario: 1. Apply the patch 2. Run updatedatabase.pl 3. Login to Koha and go to Adminstration. 4. Click on Global system preferences. 5. Search GoogleIndicTransliteration and choose value "Show". 6. Apply patches on bug 13144 7. Go to OPAC and see GoogleIndicTransliteration coming on Masthead. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> (In reply to M. Tompsett from comment #7) > Created attachment 33301 [details] [review] [review] > Bug-13211: Added Google Indic Transliteration as a System Preference Sorry for the blip. git bz thought it should attach here, because I applied 13144 in order to test 13211. I believe the status was passed QA before. Patch pushed to master. Thanks Amit! |