Summary: | staff marc preview not wrapping | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
example marc preview in staff
Bug 13151 - staff marc preview not wrapping Bug 13151 - staff marc preview not wrapping [PASSED QA] Bug 13151 - staff marc preview not wrapping |
Created attachment 33529 [details] [review] Bug 13151 - staff marc preview not wrapping The MARC preview available on the staff client detail page doesn't wrap long lines of text because it uses a huge block of whitespace-formatted text in a <pre> tag. The OPAC doesn't have this problem because the MARC preview is formated in a table. This patch copies the OPAC's "plainMARC.xsl" file for use in the staff client. The preview modal has been converted to use Bootstrap following the method used in Bug 12755 To test, apply the patch and clear your browser cache. View the detail page for a bibliographic record in the staff client. Click the link to show the MARC preview. Confirm that the modal looks correct, works correctly, and adapts gracefully to different browser widths. Confirm that the MARC preview and Card links still work from Z39.50 searches. Note: This patch assumes that UNIMARC records display correctly using xslt/plainMARC.xsl. Please let me know if that is wrong. Created attachment 33551 [details] [review] Bug 13151 - staff marc preview not wrapping The MARC preview available on the staff client detail page doesn't wrap long lines of text because it uses a huge block of whitespace-formatted text in a <pre> tag. The OPAC doesn't have this problem because the MARC preview is formated in a table. This patch copies the OPAC's "plainMARC.xsl" file for use in the staff client. The preview modal has been converted to use Bootstrap following the method used in Bug 12755 To test, apply the patch and clear your browser cache. View the detail page for a bibliographic record in the staff client. Click the link to show the MARC preview. Confirm that the modal looks correct, works correctly, and adapts gracefully to different browser widths. Confirm that the MARC preview and Card links still work from Z39.50 searches. Note: This patch assumes that UNIMARC records display correctly using xslt/plainMARC.xsl. Please let me know if that is wrong. Signed-off-by: Frederic Demians <f.demians@tamil.fr> I confirm it works: nice modal dialog box; display aligned on opac display; works also with Unimarc biblios. Created attachment 33796 [details] [review] [PASSED QA] Bug 13151 - staff marc preview not wrapping The MARC preview available on the staff client detail page doesn't wrap long lines of text because it uses a huge block of whitespace-formatted text in a <pre> tag. The OPAC doesn't have this problem because the MARC preview is formated in a table. This patch copies the OPAC's "plainMARC.xsl" file for use in the staff client. The preview modal has been converted to use Bootstrap following the method used in Bug 12755 To test, apply the patch and clear your browser cache. View the detail page for a bibliographic record in the staff client. Click the link to show the MARC preview. Confirm that the modal looks correct, works correctly, and adapts gracefully to different browser widths. Confirm that the MARC preview and Card links still work from Z39.50 searches. Note: This patch assumes that UNIMARC records display correctly using xslt/plainMARC.xsl. Please let me know if that is wrong. Signed-off-by: Frederic Demians <f.demians@tamil.fr> I confirm it works: nice modal dialog box; display aligned on opac display; works also with Unimarc biblios. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch pushed to master. Thanks Owen! |
Created attachment 32796 [details] example marc preview in staff When you're in the staff client and click the marc preview you link you have to scroll left to right to see the whole thing because it doesn't wrap. In the OPAC it looks much cleaner. Could we use that layout in the staff client since the staff are the people who care about MARC - not the patrons.