Summary: | Duplicate phone hold notices when using Talking Tech | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
Component: | Notices | Assignee: | Kyle M Hall (khall) <kyle> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | jonathan.druart, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 13152 - Duplicate phone hold notices when using Talking Tech
Bug 13152 - Duplicate phone hold notices when using Talking Tech Bug 13152 - Duplicate phone hold notices when using Talking Tech [PASSED QA] Bug 13152 - Duplicate phone hold notices when using Talking Tech |
Description
Kyle M Hall (khall)
2014-10-28 12:57:09 UTC
Created attachment 32821 [details] [review] Bug 13152 - Duplicate phone hold notices when using Talking Tech If a library is using Talking Tech for phone notices, any waiting hold phone notice will show up twice! This is because Koha generates on at the time the hold is set to waiting, and then the cronjob TalkingTech_itiva_outbound.pl generates it's own notice as well. The former notice will always have a status of 'pending', as the TalkingTech_itiva_inbound.pl script will update the notice the outbound script created. The solution is to prevent Koha from creating a phone notice for waiting holds if TT is enabled, and let the cron script do it. Test Plan: 1) Enable Talking Tech from the system preferences 2) Set a hold waiting phone notice in the notices and slips editor 3) Choose a patron, enable hold phone notices for that patron 4) Place a hold for a patron, and check it in so it's marked as waiting 5) Note the phone notice generated for the patron 6) Apply this patch 7) Repeat step 4 8) Note that this time, a phone hold waiting notice is not generated Created attachment 32823 [details] [review] Bug 13152 - Duplicate phone hold notices when using Talking Tech If a library is using Talking Tech for phone notices, any waiting hold phone notice will show up twice! This is because Koha generates on at the time the hold is set to waiting, and then the cronjob TalkingTech_itiva_outbound.pl generates it's own notice as well. The former notice will always have a status of 'pending', as the TalkingTech_itiva_inbound.pl script will update the notice the outbound script created. The solution is to prevent Koha from creating a phone notice for waiting holds if TT is enabled, and let the cron script do it. Test Plan: 1) Enable Talking Tech from the system preferences 2) Set a hold waiting phone notice in the notices and slips editor 3) Choose a patron, enable hold phone notices for that patron 4) Place a hold for a patron, and check it in so it's marked as waiting 5) Note the phone notice generated for the patron 6) Apply this patch 7) Repeat step 4 8) Note that this time, a phone hold waiting notice is not generated Note that the code assumes that the phone can only be defined if the pref TalkingTechItivaPhoneNotification is on. (tools/letter.tt ~l.372 [% ELSIF letter.message_transport_type == "phone" and not Koha.Preference("TalkingTechItivaPhoneNotification") %]). Created attachment 33917 [details] [review] Bug 13152 - Duplicate phone hold notices when using Talking Tech If a library is using Talking Tech for phone notices, any waiting hold phone notice will show up twice! This is because Koha generates on at the time the hold is set to waiting, and then the cronjob TalkingTech_itiva_outbound.pl generates it's own notice as well. The former notice will always have a status of 'pending', as the TalkingTech_itiva_inbound.pl script will update the notice the outbound script created. The solution is to prevent Koha from creating a phone notice for waiting holds if TT is enabled, and let the cron script do it. Test Plan: 1) Enable Talking Tech from the system preferences 2) Set a hold waiting phone notice in the notices and slips editor 3) Choose a patron, enable hold phone notices for that patron 4) Place a hold for a patron, and check it in so it's marked as waiting 5) Note the phone notice generated for the patron 6) Apply this patch 7) Repeat step 4 8) Note that this time, a phone hold waiting notice is not generated Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 33926 [details] [review] [PASSED QA] Bug 13152 - Duplicate phone hold notices when using Talking Tech If a library is using Talking Tech for phone notices, any waiting hold phone notice will show up twice! This is because Koha generates on at the time the hold is set to waiting, and then the cronjob TalkingTech_itiva_outbound.pl generates it's own notice as well. The former notice will always have a status of 'pending', as the TalkingTech_itiva_inbound.pl script will update the notice the outbound script created. The solution is to prevent Koha from creating a phone notice for waiting holds if TT is enabled, and let the cron script do it. Test Plan: 1) Enable Talking Tech from the system preferences 2) Set a hold waiting phone notice in the notices and slips editor 3) Choose a patron, enable hold phone notices for that patron 4) Place a hold for a patron, and check it in so it's marked as waiting 5) Note the phone notice generated for the patron 6) Apply this patch 7) Repeat step 4 8) Note that this time, a phone hold waiting notice is not generated Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Amends condition with an additional or statement. Shoudn't affect anything but phone notices. Change appears logical. Patch pushed to master. Thanks Kyle! |