| Summary: | Display cardnumber of borrower who made a suggestion in suggestion.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marjorie Barry-Vila <marjorie.barry-vila> |
| Component: | Acquisitions | Assignee: | Frédéric Demians <f.demians> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | f.demians, paola.rossi, tomascohen, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | /cgi-bin/koha/suggestion/suggestion.pl | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 13156 Display borrower's cardnumber who did a suggestion in suggestion.pl
[Signed-off] Bug 13156 Display borrower's cardnumber who did a suggestion in suggestion.pl [PASSED QA] Bug 13156 Display borrower's cardnumber who did a suggestion in suggestion.pl |
||
|
Description
Marjorie Barry-Vila
2014-10-28 20:24:17 UTC
Created attachment 33133 [details] [review] Bug 13156 Display borrower's cardnumber who did a suggestion in suggestion.pl To avoid homonyms, it would be nice if the card number is displayed in the user suggestion.pl. Currently, consult the record of the user to know exactly who made the suggestion. TEST PLAN: Apply the patch. Go on suggestion.pl. Check that nothing has changed, except that cardnumbers are displayed in 'Suggested by' column. I've tried to apply the patch against master 3.17.00.052 HEAD 13113 Applying: Bug 13156 Display borrower's cardnumber who did a suggestion in suggestion.pl Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt Auto-merging C4/Suggestions.pm Failed to merge in the changes. Patch failed at 0001 Bug 13156 Display borrower's cardnumber who did a suggestion in suggestion.pl So I pass the patch to "Patch doesn't apply" status. NB. On master, in the template, from patron's "Surname, firstname" there is a "mailto" link in the template. The test plan requires "consulting the record of the user, to know exactly who made the suggestion". Please, does the test plan require the barcode to be a link or not? In case, which link? Thanks. Created attachment 37777 [details] [review] [Signed-off] Bug 13156 Display borrower's cardnumber who did a suggestion in suggestion.pl To avoid homonyms, it would be nice if the card number is displayed in the user suggestion.pl. Currently, consult the record of the user to know exactly who made the suggestion. TEST PLAN: Apply the patch. Go on suggestion.pl. Check that nothing has changed, except that cardnumbers are displayed in 'Suggested by' column. Resolved an easy conflict while applying. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 38041 [details] [review] [PASSED QA] Bug 13156 Display borrower's cardnumber who did a suggestion in suggestion.pl To avoid homonyms, it would be nice if the card number is displayed in the user suggestion.pl. Currently, consult the record of the user to know exactly who made the suggestion. TEST PLAN: Apply the patch. Go on suggestion.pl. Check that nothing has changed, except that cardnumbers are displayed in 'Suggested by' column. Resolved an easy conflict while applying. Followed test plan. Works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch pushed to master. Thanks Frederic! |