Summary: | C4::Templates::themelanguage fails if the DB is not populated | ||
---|---|---|---|
Product: | Koha | Reporter: | Paola Rossi <paola.rossi> |
Component: | Installation and upgrade (web-based installer) | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | blocker | ||
Priority: | P1 - high | CC: | cbrannon, gmcharlt, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 10582, 17982 | ||
Attachments: |
Bug 13169: C4::Templates::themelanguage fails if the DB is not populated
[SIGNED OFF] Bug 13169: C4::Templates::themelanguage fails if the DB is not populated [PASSED QA] Bug 13169: C4::Templates::themelanguage fails if the DB is not populated |
Description
Paola Rossi
2014-10-30 14:29:49 UTC
Created attachment 33073 [details] [review] Bug 13169: C4::Templates::themelanguage fails if the DB is not populated With the aim to remove hardcoded themes the C4::Templates::themelanguage got dependent on the DB being populated. This patch reintroduced the hardcoded defaults as a last resort. To test: - Do a fresh install, clean your browser's cache, empty DB - Open the staff interface => FAIL: A "Software error" screen shows "Template process failed: file error..." - Apply the patch - Reload => SUCCESS: The webinstaller prompts for login correctly. - Sign off :-D Regards Please test this one ASAP. Created attachment 33115 [details] [review] [SIGNED OFF] Bug 13169: C4::Templates::themelanguage fails if the DB is not populated With the aim to remove hardcoded themes the C4::Templates::themelanguage got dependent on the DB being populated. This patch reintroduced the hardcoded defaults as a last resort. To test: - Do a fresh install, clean your browser's cache, empty DB - Open the staff interface => FAIL: A "Software error" screen shows "Template process failed: file error..." - Apply the patch - Reload => SUCCESS: The webinstaller prompts for login correctly. - Sign off :-D Regards Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Created attachment 33116 [details] [review] [PASSED QA] Bug 13169: C4::Templates::themelanguage fails if the DB is not populated With the aim to remove hardcoded themes the C4::Templates::themelanguage got dependent on the DB being populated. This patch reintroduced the hardcoded defaults as a last resort. To test: - Do a fresh install, clean your browser's cache, empty DB - Open the staff interface => FAIL: A "Software error" screen shows "Template process failed: file error..." - Apply the patch - Reload => SUCCESS: The webinstaller prompts for login correctly. - Sign off :-D Regards Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patch pushed to master. /me feels relieved :-D |