Bug 13169

Summary: C4::Templates::themelanguage fails if the DB is not populated
Product: Koha Reporter: Paola Rossi <paola.rossi>
Component: Installation and upgrade (web-based installer)Assignee: Tomás Cohen Arazi <tomascohen>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: blocker    
Priority: P1 - high CC: cbrannon, gmcharlt, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 10582, 17982    
Attachments: Bug 13169: C4::Templates::themelanguage fails if the DB is not populated
[SIGNED OFF] Bug 13169: C4::Templates::themelanguage fails if the DB is not populated
[PASSED QA] Bug 13169: C4::Templates::themelanguage fails if the DB is not populated

Description Paola Rossi 2014-10-30 14:29:49 UTC
On master 3.17.00.043 the web installing send the error message:

Software error:

Template process failed: file error - doc-head-open.inc: not found at /var/root-koha/bug-7162/C4/Templates.pm line 127.

For help, please send mail to the webmaster (webmaster@linux-test), giving this error message and the time and date of the error. 

So the master can't be installed.
Comment 1 Tomás Cohen Arazi 2014-10-31 14:31:30 UTC Comment hidden (obsolete)
Comment 2 Tomás Cohen Arazi 2014-10-31 18:57:22 UTC
Please test this one ASAP.
Comment 3 Nick Clemens 2014-10-31 21:14:37 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2014-11-01 08:59:37 UTC
Created attachment 33116 [details] [review]
[PASSED QA] Bug 13169: C4::Templates::themelanguage fails if the DB is not populated

With the aim to remove hardcoded themes the C4::Templates::themelanguage
got dependent on the DB being populated. This patch reintroduced the
hardcoded defaults as a last resort.

To test:
- Do a fresh install, clean your browser's cache, empty DB
- Open the staff interface
=> FAIL: A "Software error" screen shows "Template process failed: file error..."
- Apply the patch
- Reload
=> SUCCESS: The webinstaller prompts for login correctly.
- Sign off :-D

Regards

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2014-11-01 13:47:23 UTC
Patch pushed to master.

/me feels relieved :-D