| Summary: | Circulation page layout problem when OnSiteCheckoutsForce is enabled | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Circulation | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | gmcharlt, kyle.m.hall, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 10860, 13183 | ||
| Bug Blocks: | 13184 | ||
| Attachments: |
Bug 13179 - Circulation page layout problem when OnSiteCheckoutsForce is enabled
Bug 13179 - Circulation page layout problem when OnSiteCheckoutsForce is enabled [PASSED QA] Bug 13179 - Circulation page layout problem when OnSiteCheckoutsForce is enabled |
||
|
Description
Owen Leonard
2014-10-31 13:53:40 UTC
Created attachment 33086 [details] [review] Bug 13179 - Circulation page layout problem when OnSiteCheckoutsForce is enabled The circulation page layout needs to work correctly for various combinations of restrictions, no restrictions, and restrictions with OnSiteCheckoutsForce enabled. This patch makes some minor accomodation for all. To test, load a patron for checkout under the following conditions: 1. OnSiteCheckoutsForce and patron is not blocked from checkout 2. OnSiteCheckoutsForce is off, patron is blocked from checkout (for being expired or restricted). 3. OnSiteCheckoutsForce is on and patron is not blocked from checkout 4. OnSiteCheckoutsForce is on and patron is blocked from checkout The page layout should look correct for all these cases, with a clean two-column layout of [ checkout form | messages ] in all cases except Created attachment 33091 [details] [review] Bug 13179 - Circulation page layout problem when OnSiteCheckoutsForce is enabled The circulation page layout needs to work correctly for various combinations of restrictions, no restrictions, and restrictions with OnSiteCheckoutsForce enabled. This patch makes some minor accomodation for all. To test, load a patron for checkout under the following conditions: 1. OnSiteCheckoutsForce and patron is not blocked from checkout 2. OnSiteCheckoutsForce is off, patron is blocked from checkout (for being expired or restricted). 3. OnSiteCheckoutsForce is on and patron is not blocked from checkout 4. OnSiteCheckoutsForce is on and patron is blocked from checkout The page layout should look correct for all these cases, with a clean two-column layout of [ checkout form | messages ] in all cases except Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Created attachment 33112 [details] [review] [PASSED QA] Bug 13179 - Circulation page layout problem when OnSiteCheckoutsForce is enabled The circulation page layout needs to work correctly for various combinations of restrictions, no restrictions, and restrictions with OnSiteCheckoutsForce enabled. This patch makes some minor accomodation for all. To test, load a patron for checkout under the following conditions: 1. OnSiteCheckoutsForce and patron is not blocked from checkout 2. OnSiteCheckoutsForce is off, patron is blocked from checkout (for being expired or restricted). 3. OnSiteCheckoutsForce is on and patron is not blocked from checkout 4. OnSiteCheckoutsForce is on and patron is blocked from checkout The page layout should look correct for all these cases, with a clean two-column layout of [ checkout form | messages ] in all cases except Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Applied on top of 10860. Works as described. Patch pushed to master. Thanks Owen! |