Description
Liz Rea
2014-11-07 08:21:32 UTC
Created attachment 33367 [details] [review] Bug 13218 - usability enhancements for z39.50 searches This patch rearranges the layout of the z39.50 search pages in cataloguing and authorities. There should be no functional change to z-target searching, all functions should remain the same. Changes: * 2 columns of search fields condensed into one * zTargets moved from below the search fields to beside them * rearranged search fields into perceived frequency of usage, from most used to least * changed label of Raw (any) to Keyword (any) To test: * click cataloguing -> new from z39.50/SRU * observe how the layout has changed * import a record or two using the search - there has been no change to the function, it should all be working. * Click Authorities -> new from z39.50 * observe how the layout has changed * import an authority or two using the search - there has been no change to the function, it should all be working. * sign off if you think these changes are nice. Comments and suggestions are also welcome regarding this change. Created attachment 33382 [details]
Search dialog box
Created attachment 33383 [details]
Search result
I like the new layout. But do you thing you could do something for the unsightly scroll bars that are displayed on search dialog box and search result page? It would be great to have dialog box sized properly to display all its content without scroll-bars. Yep, will have a look at that. Hi Frédéric, I think it's sensible to have a vertical scroll on the search results, you're right there shouldn't be one on the search page itself though. Does that seem sensible to you? Liz Created attachment 33389 [details] [review] Bug 13218 - usability enhancements for z39.50 searches This patch rearranges the layout of the z39.50 search pages in cataloguing and authorities. There should be no functional change to z-target searching, all functions should remain the same. Changes: * 2 columns of search fields condensed into one * zTargets moved from below the search fields to beside them * rearranged search fields into perceived frequency of usage, from most used to least * changed label of Raw (any) to Keyword (any) To test: * click cataloguing -> new from z39.50/SRU * observe how the layout has changed * import a record or two using the search - there has been no change to the function, it should all be working. * Click Authorities -> new from z39.50 * observe how the layout has changed * import an authority or two using the search - there has been no change to the function, it should all be working. * sign off if you think these changes are nice. Comments and suggestions are also welcome regarding this change. (In reply to Liz Rea from comment #6) > I think it's sensible to have a vertical scroll on the search results, > you're right there shouldn't be one on the search page itself though. Yes, of course. My screenshot was pointing to the vertical scrollbar. That was an error. I was meaning that the horizontal scrollbar is superfluous. Created attachment 33393 [details] [review] Bug 13218 - usability enhancements for z39.50 searches This patch rearranges the layout of the z39.50 search pages in cataloguing and authorities. There should be no functional change to z-target searching, all functions should remain the same. Changes: * 2 columns of search fields condensed into one * zTargets moved from below the search fields to beside them * rearranged search fields into perceived frequency of usage, from most used to least * changed label of Raw (any) to Keyword (any) To test: * click cataloguing -> new from z39.50/SRU * observe how the layout has changed * import a record or two using the search - there has been no change to the function, it should all be working. * Click Authorities -> new from z39.50 * observe how the layout has changed * import an authority or two using the search - there has been no change to the function, it should all be working. * sign off if you think these changes are nice. Comments and suggestions are also welcome regarding this change. Signed-off-by: Frederic Demians <f.demians@tamil.fr> Nice evolution of the z3950 search/result pages. Created attachment 33728 [details] [review] Bug 13218 - fixing acquisitions z39.50 interface to be consistent with the others. Changes: * Two columns of search fields into one * moves targets from below search fields to the right of them To test: * Create a basket in acquisitions * attempt to add a record to the order from an external source * note the changes to the layout * complete a couple of additions to the basket - functionality should be unchanged. If you like the changes, sign off :) needs signoff for additional patch to acquisitions module z-search Created attachment 33747 [details] [review] Bug 13218 - fixing acquisitions z39.50 interface to be consistent with the others. Changes: * Two columns of search fields into one * moves targets from below search fields to the right of them To test: * Create a basket in acquisitions * attempt to add a record to the order from an external source * note the changes to the layout * complete a couple of additions to the basket - functionality should be unchanged. If you like the changes, sign off :) Signed-off-by: Frederic Demians <f.demians@tamil.fr> Ok. Consistency welcomed! Idea for another patch: Template factorization = One include TT used in z39.50 searches, from cataloging, and from acquisition. Yes, actually that is a fantastic idea - though the search fields are a bit different for each of these screens, I learned while I was looking at it. There is probably a way around that, I'll have a think. Maybe a phase two for this little project. :) Liz Comment on attachment 33747 [details] [review] Bug 13218 - fixing acquisitions z39.50 interface to be consistent with the others. Review of attachment 33747 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt @@ +99,5 @@ > + <li><label for="controlnumber">Control no.: </label> <input type="text" id="controlnumber" name="controlnumber" value="" /></li> > + <li><label for="author">Author: </label> <input type="text" id="author" name="author" value="[% author %]" /></li> > + <li><label for="issn">ISSN: </label> <input type="text" id="issn" name="issn" value="[% issn %]" /></li> > + <li> <label for="subject">Subject heading: </label> <input type="text" id="subject" name="subject" value="" /></li> > + <li><label for="dewey">Dewey: </label> <input type="text" id="dewey" name="dewey" value="" /></li></ol> At the end of the line, there is a </ol> which shouldn't be there. I've missed it when signing-off the patch. Could you fix that? (In reply to Liz Rea from comment #14) > Yes, actually that is a fantastic idea - though the search fields are a bit > different for each of these screens, I learned while I was looking at it. > > There is probably a way around that, I'll have a think. Maybe a phase two > for this little project. :) That doesn't seem so easy to do! Obviously, acquisition z3950 code comes from cataloging code. But it has diverged since. Created attachment 33768 [details] [review] Bug 13218 - fixing acquisitions z39.50 interface to be consistent with the others. Changes: * Two columns of search fields into one * moves targets from below search fields to the right of them To test: * Create a basket in acquisitions * attempt to add a record to the order from an external source * note the changes to the layout * complete a couple of additions to the basket - functionality should be unchanged. If you like the changes, sign off :) Signed-off-by: Frederic Demians <f.demians@tamil.fr> Ok. Consistency welcomed! Created attachment 34246 [details] [review] [SIGNED-OFF] Bug 13218 - fixing acquisitions z39.50 interface to be consistent with the others. Changes: * Two columns of search fields into one * moves targets from below search fields to the right of them To test: * Create a basket in acquisitions * attempt to add a record to the order from an external source * note the changes to the layout * complete a couple of additions to the basket - functionality should be unchanged. If you like the changes, sign off :) Signed-off-by: Frederic Demians <f.demians@tamil.fr> Ok. Consistency welcomed! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 34270 [details] [review] Bug 13218 - usability enhancements for z39.50 searches This patch rearranges the layout of the z39.50 search pages in cataloguing and authorities. There should be no functional change to z-target searching, all functions should remain the same. Changes: * 2 columns of search fields condensed into one * zTargets moved from below the search fields to beside them * rearranged search fields into perceived frequency of usage, from most used to least * changed label of Raw (any) to Keyword (any) To test: * click cataloguing -> new from z39.50/SRU * observe how the layout has changed * import a record or two using the search - there has been no change to the function, it should all be working. * Click Authorities -> new from z39.50 * observe how the layout has changed * import an authority or two using the search - there has been no change to the function, it should all be working. * sign off if you think these changes are nice. Comments and suggestions are also welcome regarding this change. Signed-off-by: Frederic Demians <f.demians@tamil.fr> Nice evolution of the z3950 search/result pages. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 34271 [details] [review] Bug 13218 - fixing acquisitions z39.50 interface to be consistent with the others. Changes: * Two columns of search fields into one * moves targets from below search fields to the right of them To test: * Create a basket in acquisitions * attempt to add a record to the order from an external source * note the changes to the layout * complete a couple of additions to the basket - functionality should be unchanged. If you like the changes, sign off :) Signed-off-by: Frederic Demians <f.demians@tamil.fr> Ok. Consistency welcomed! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 34272 [details] [review] Bug 13218: (qa-follow-up) replace tab with spaces Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Qaed with bug 7741. Created attachment 34497 [details] [review] Bug 13218: (RM followup) only scroll on actually variable stuff Most of the page contents have fixed size. The only exception is the targets list. If the target list grows, then the whole page needs to be scrolled in order to reach the buttons. We should make the z3950 targets area scrollable, and remove scrolbars from all over the place. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Created attachment 34498 [details]
Current view with lots of targets
Created attachment 34499 [details]
Proposed view with lots of targets
I was about to push this one, along with my followup. But then I realized there's no rush to push this one, so: do you agree with the followup? I agree with your followup, please go ahead and push it :) Cheers, Liz Created attachment 34585 [details] [review] Bug 13218: (RM followup) only scroll on actually variable stuff Most of the page contents have fixed size. The only exception is the targets list. If the target list grows, then the whole page needs to be scrolled in order to reach the buttons. We should make the z3950 targets area scrollable, and remove scrolbars from all over the place. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Patches pushed to master. Thanks Liz! String changes, held for 3.18.3 Pushed to 3.18.x will be in 3.18.3 |