Bug 13222

Summary:	Accessors for import_record.status have variable names suggesting overlay_status
Product:	Koha	Reporter:	Olli-Antti Kivilahti <olli-antti.kivilahti>
Component:	Architecture, internals, and plumbing	Assignee:	Olli-Antti Kivilahti <olli-antti.kivilahti>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	trivial
Priority:	P5 - low	CC:	tomascohen
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Bug 13222 - Accessors for import_record.status have variable names suggesting overlay_status Bug 13222 - Accessors for import_record.status have variable names suggesting overlay_status [PASSED QA] Bug 13222 - Accessors for import_record.status have variable names suggesting overlay_status

Description Olli-Antti Kivilahti 2014-11-07 15:04:18 UTC

While trying to figure out what overlay_status is used for, noticed that SetImportRecordStatus() and GetImportRecordStatus() are named all wrong.
Obviously sloppily copypasted from SetImportRecordOverlayStatus();

This minor patch adds some make-up to the codebase.

While were at it, it would be nice to get some more extensive function documentation about what they are meant to do?

Comment 1 Olli-Antti Kivilahti 2014-11-07 15:08:34 UTC Comment hidden (obsolete)

Created attachment 33380 [details] [review]
Bug 13222 - Accessors for import_record.status have variable names suggesting overlay_status

TODO:: Somebody who knows what these are about could write some documentation about it.

Comment 2 Jonathan Druart 2014-11-12 14:00:51 UTC Comment hidden (obsolete)

Created attachment 33486 [details] [review]
Bug 13222 - Accessors for import_record.status have variable names suggesting overlay_status

TODO:: Somebody who knows what these are about could write some documentation about it.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

Comment 3 Katrin Fischer 2014-11-13 21:10:46 UTC

Created attachment 33538 [details] [review]
[PASSED QA] Bug 13222 - Accessors for import_record.status have variable names suggesting overlay_status

TODO:: Somebody who knows what these are about could write some documentation about it.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>

Comment 4 Tomás Cohen Arazi (tcohen) 2015-01-15 00:38:13 UTC

Patch pushed to master.

Thanks Olli!