Summary: | Suggestion date filters have a style problem | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Screenshot
Bug 13229 - Suggestion date filters have a style problem Bug 13229 - Suggestion date filters have a style problem [PASSED QA] Bug 13229 - Suggestion date filters have a style problem |
Created attachment 33456 [details] [review] Bug 13229 - Suggestion date filters have a style problem The suggestion date filters appear to be picking up a style change which wasn't anticipated for the suggestions page markup. This patch solves the problem by simplifying and standardizing the markup, including simplifications to the label structure. To test, apply the patch and view the suggestions management page in the staff client. Expand the "suggestion information" filter section and confirm that the label/input structure looks correct and works correctly. Created attachment 33458 [details] [review] Bug 13229 - Suggestion date filters have a style problem The suggestion date filters appear to be picking up a style change which wasn't anticipated for the suggestions page markup. This patch solves the problem by simplifying and standardizing the markup, including simplifications to the label structure. To test, apply the patch and view the suggestions management page in the staff client. Expand the "suggestion information" filter section and confirm that the label/input structure looks correct and works correctly. Signed-off-by: Blou <philippe.blouin@inlibro.com> Looks good on Firefox 28, at least. Looks good on Firefox 28, at least. Created attachment 33466 [details] [review] [PASSED QA] Bug 13229 - Suggestion date filters have a style problem The suggestion date filters appear to be picking up a style change which wasn't anticipated for the suggestions page markup. This patch solves the problem by simplifying and standardizing the markup, including simplifications to the label structure. To test, apply the patch and view the suggestions management page in the staff client. Expand the "suggestion information" filter section and confirm that the label/input structure looks correct and works correctly. Signed-off-by: Blou <philippe.blouin@inlibro.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, looking better. Patch pushed to master. Thanks Owen! |
Created attachment 33444 [details] Screenshot The date related filters on the suggestion page don't look quite right/as before.