Summary: | opacuserjs is not compatible with tracking's tools like Piwik | ||
---|---|---|---|
Product: | Koha | Reporter: | Stéphane Delaune <stephane.delaune> |
Component: | Templates | Assignee: | Stéphane Delaune <stephane.delaune> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P3 | CC: | tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
proposed patch
new proposed patch [SIGNED-OFF] Bug 13247 - Move opacuserjs at the end of opac-bottom.inc [PASSED QA] Bug 13247 - Move opacuserjs at the end of opac-bottom.inc |
Description
Stéphane Delaune
2014-11-13 13:42:26 UTC
Created attachment 33521 [details] [review] proposed patch proposed patch Comment on attachment 33521 [details] [review] proposed patch Review of attachment 33521 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc @@ +238,5 @@ > [% PROCESS jsinclude %] > > +<script type="text/javascript"> > + //<![CDATA[ > + [% IF ( opacuserjs ) %][% opacuserjs %][% END %] Wouldn't it make more sense to put the IF and END around the entire script? Why generate a hollow script section? (In reply to M. Tompsett from comment #2) > Wouldn't it make more sense to put the IF and END around the entire script? > Why generate a hollow script section? I agree. Other than that I think this change will work. Created attachment 33548 [details] [review] new proposed patch new proposed patch taking into account the suggestions Created attachment 33579 [details] [review] [SIGNED-OFF] Bug 13247 - Move opacuserjs at the end of opac-bottom.inc This patch makes opacuserjs compatible with tracking tools like Piwik Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 33600 [details] [review] [PASSED QA] Bug 13247 - Move opacuserjs at the end of opac-bottom.inc This patch makes opacuserjs compatible with tracking tools like Piwik Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Small change to enable use of opacuserjs for statistical tools like Piwik by moving it right above </body>. Works as described. Patch pushed to master. Thanks Stephane! |