| Summary: | On receiving, "vendor note" label should not be displayed if nothing to display | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Templates | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | chris, mtj, nengard, sfayle, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 12111 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 13270: Don't display "vendor note" label if nothing to display
Bug 13270: Don't display "vendor note" label if nothing to display [PASSED QA] Bug 13270: Don't display "vendor note" label if nothing to display |
||
Created attachment 33618 [details] [review] Bug 13270: Don't display "vendor note" label if nothing to display Bug 12111 removes the vendor note edition on receiving. The label should not be displayed when it's empty. Test plan: 1/ Receive an order without a vendor note and verify that the label is not displayed. 2/ Receive an order with a vendor note and verify that the note is displayed. Created attachment 34687 [details] [review] Bug 13270: Don't display "vendor note" label if nothing to display Bug 12111 removes the vendor note edition on receiving. The label should not be displayed when it's empty. Test plan: 1/ Receive an order without a vendor note and verify that the label is not displayed. 2/ Receive an order with a vendor note and verify that the note is displayed. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 34701 [details] [review] [PASSED QA] Bug 13270: Don't display "vendor note" label if nothing to display Bug 12111 removes the vendor note edition on receiving. The label should not be displayed when it's empty. Test plan: 1/ Receive an order without a vendor note and verify that the label is not displayed. 2/ Receive an order with a vendor note and verify that the note is displayed. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Works as described, small template change. Patch pushed to master. Thanks Jonathan! Pushed to 3.18.x will be in 3.18.4 Possible selection for 3.16.x Pushed to 3.16.x, will be in 3.16.10 |
On receiving (acqui/orderreceive.pl), the vendor note is no longer editable. But the label ("Vendor note:") is still displayed. It should only be displayed when it's not empty.