Summary: | t/Search.t shouldn't depend on the DB | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Test Suite | Assignee: | Chris Cormack <chris> |
Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
Severity: | normal | ||
Priority: | P5 - low | CC: | tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | |||
Bug Blocks: | 13275 | ||
Attachments: |
Bug 13278: t/Search.t shouldn't depend on the DB
Bug 13278: t/Search.t shouldn't depend on the DB [PASSED QA] Bug 13278: t/Search.t shouldn't depend on the DB Bug 13278: (QA followup) use t::lib::Mocks |
Description
Tomás Cohen Arazi (tcohen)
2014-11-18 04:04:46 UTC
Created attachment 33635 [details] [review] Bug 13278: t/Search.t shouldn't depend on the DB To reproduce: - Stop your MySQL server: $ sudo service mysql stop - Run $ prove t/Search.t => FAIL: some tests fail because of mysql stopped To test (MySQL still stopped) - Apply the patch - Run $ prove t/Search.t => SUCCESS: tests pass because the ycan be loaded regardless of the absence of the DB server - Sign off :-D Regards Created attachment 33642 [details] [review] Bug 13278: t/Search.t shouldn't depend on the DB To reproduce: - Stop your MySQL server: $ sudo service mysql stop - Run $ prove t/Search.t => FAIL: some tests fail because of mysql stopped To test (MySQL still stopped) - Apply the patch - Run $ prove t/Search.t => SUCCESS: tests pass because the ycan be loaded regardless of the absence of the DB server - Sign off :-D Regards Signed-off-by: Magnus Enger <digitalutvikling@gmail.com> Turned off MySQL and ran the tests before and after the patch. Works as advertised. Created attachment 33697 [details] [review] [PASSED QA] Bug 13278: t/Search.t shouldn't depend on the DB To reproduce: - Stop your MySQL server: $ sudo service mysql stop - Run $ prove t/Search.t => FAIL: some tests fail because of mysql stopped To test (MySQL still stopped) - Apply the patch - Run $ prove t/Search.t => SUCCESS: tests pass because the ycan be loaded regardless of the absence of the DB server - Sign off :-D Regards Signed-off-by: Magnus Enger <digitalutvikling@gmail.com> Turned off MySQL and ran the tests before and after the patch. Works as advertised. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Created attachment 33713 [details] [review] Bug 13278: (QA followup) use t::lib::Mocks Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Patch pushed to master. |