Summary: | updatedatabase throws an error if opacthemes is not set | ||
---|---|---|---|
Product: | Koha | Reporter: | Colin Campbell <colin.campbell> |
Component: | Installation and upgrade (web-based installer) | Assignee: | Colin Campbell <colin.campbell> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, gmcharlt, mtj, tomascohen |
Version: | 3.18 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Proposed patch
Bug 13285 Do the right thing if opacthemes is not set [PASSED QA] Bug 13285 Do the right thing if opacthemes is not set |
Description
Colin Campbell
2014-11-18 14:06:38 UTC
Created attachment 33652 [details] [review] Proposed patch Created attachment 34622 [details] [review] Bug 13285 Do the right thing if opacthemes is not set If opacthemes is not defined updatedatabase reports the subsequent warnings as an error. Take account of the case where it is not set and default that to bootstrap. This is probably a rare occurence, but should be handled Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Bit worried, if opacthemes is not defined, should we point this out as a possible problem? I misread - the value will be set. Created attachment 34697 [details] [review] [PASSED QA] Bug 13285 Do the right thing if opacthemes is not set If opacthemes is not defined updatedatabase reports the subsequent warnings as an error. Take account of the case where it is not set and default that to bootstrap. This is probably a rare occurence, but should be handled Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patch pushed to master. Good catch Colin! Pushed to 3.18.x will be in 3.18.3 Contains DB changes, passing for 3.16.x |