| Summary: | Calendar with weekly repeating holidays completely broken by DataTables upgrade | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Tools | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | blocker | ||
| Priority: | P5 - low | CC: | jonathan.druart, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 13289: document.write breaks DataTables
[SIGNED-OFF] Bug 13289: document.write breaks DataTables [PASSED QA] Bug 13289: document.write breaks DataTables |
||
|
Description
Owen Leonard
2014-11-18 18:07:29 UTC
Created attachment 33682 [details] [review] Bug 13289: document.write breaks DataTables The document.write in a td seems to brake the page with a new version of DataTables. This patch replaces a dirty piece of code with another one (but this one works...) Test plan: Create repeatable holidays and verify the page loads correctly. Created attachment 33683 [details] [review] [SIGNED-OFF] Bug 13289: document.write breaks DataTables The document.write in a td seems to brake the page with a new version of DataTables. This patch replaces a dirty piece of code with another one (but this one works...) Test plan: Create repeatable holidays and verify the page loads correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Works to fix the problem. The code is definitely an improvement. Created attachment 33694 [details] [review] [PASSED QA] Bug 13289: document.write breaks DataTables The document.write in a td seems to brake the page with a new version of DataTables. This patch replaces a dirty piece of code with another one (but this one works...) Test plan: Create repeatable holidays and verify the page loads correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Works to fix the problem. The code is definitely an improvement. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, fixes critical problem. Passes tests and QA script. Patch pushed to master. Thanks Jonathan! |