| Summary: | C4::Acq::GetParcel is not used and can be removed | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | matted-34813, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 12826 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 13318: Delete C4::Acq::GetParcel
Bug-13318-Delete-C4-Acq-GetParcel.patch [PASSED QA] Bug 13318: Delete C4::Acq::GetParcel |
||
|
Description
Jonathan Druart
2014-11-21 10:48:14 UTC
Created attachment 33774 [details] [review] Bug 13318: Delete C4::Acq::GetParcel Test plan: git grep GetParcel should not return use of this subroutine. Created attachment 34011 [details] [review] Bug-13318-Delete-C4-Acq-GetParcel.patch Reviewed code. # before patch git grep GetParcel C4/Acquisition.pm: &GetParcels &GetParcel C4/Acquisition.pm:=head3 GetParcel C4/Acquisition.pm: @results = &GetParcel($booksellerid, $code, $date); C4/Acquisition.pm:sub GetParcel { C4/Acquisition.pm:=head3 GetParcels C4/Acquisition.pm: $results = &GetParcels($bookseller, $order, $code, $datefrom, $dateto); C4/Acquisition.pm:sub GetParcels { #after patch git grep GetParcel C4/Acquisition.pm: &GetParcels C4/Acquisition.pm:=head3 GetParcels C4/Acquisition.pm: $results = &GetParcels($bookseller, $order, $code, $datefrom, $dateto); C4/Acquisition.pm:sub GetParcels { Dead code removed. Created attachment 34150 [details] [review] [PASSED QA] Bug 13318: Delete C4::Acq::GetParcel Test plan: git grep GetParcel should not return use of this subroutine. Signed-off-by: wajasu <matted@34813.mypacks.net> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch pushed to master. Thanks Jonathan! |