Summary: | On inserting an order, the parent_ordernumber attribute is not set to the object | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, katrin.fischer, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 12830 | ||
Bug Blocks: | |||
Attachments: |
Bug 13319: Fix Koha::Acq::Order should set parent_ordernumber
Bug 13319: Fix Koha::Acq::Order should set parent_ordernumber [PASSED QA] Bug 13319: Fix Koha::Acq::Order should set parent_ordernumber |
Description
Jonathan Druart
2014-11-21 11:21:09 UTC
Created attachment 33775 [details] [review] Bug 13319: Fix Koha::Acq::Order should set parent_ordernumber The tests highligh the problem: if the parent_ordernumber attribute is not set on inserting an order, the object returned by the method does not contain the value (undef). Test plan: Verify the tests are consistent and prove t/db_dependent/Acquisition/CancelReceipt.t should return green. You can also verify that receive partially an order and cancel the receipt work as expected. Created attachment 34686 [details] [review] Bug 13319: Fix Koha::Acq::Order should set parent_ordernumber The tests highligh the problem: if the parent_ordernumber attribute is not set on inserting an order, the object returned by the method does not contain the value (undef). Test plan: Verify the tests are consistent and prove t/db_dependent/Acquisition/CancelReceipt.t should return green. You can also verify that receive partially an order and cancel the receipt work as expected. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 34702 [details] [review] [PASSED QA] Bug 13319: Fix Koha::Acq::Order should set parent_ordernumber The tests highligh the problem: if the parent_ordernumber attribute is not set on inserting an order, the object returned by the method does not contain the value (undef). Test plan: Verify the tests are consistent and prove t/db_dependent/Acquisition/CancelReceipt.t should return green. You can also verify that receive partially an order and cancel the receipt work as expected. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Tested partial receives and 'undoing' the receipt. Tests didn't run on my normal database with acq data, but passed on a database without. Patch pushed to master. Thanks Jonathan! Pushed to 3.18.x will be in 3.18.4 |