Summary: | Rename Kurdish translation files | ||
---|---|---|---|
Product: | Koha | Reporter: | Bernardo Gonzalez Kriegel <bgkriegel> |
Component: | I18N/L10N | Assignee: | Bernardo Gonzalez Kriegel <bgkriegel> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | f.demians, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 12250 | ||
Bug Blocks: | |||
Attachments: |
Bug 13328: Rename Kurdish translation files
[SIGNED OFF] Bug 13328: Rename Kurdish translation files [PASSED QA] Bug 13328: Rename Kurdish translation files |
Description
Bernardo Gonzalez Kriegel
2014-11-22 13:25:44 UTC
Created attachment 33809 [details] [review] Bug 13328: Rename Kurdish translation files Kurdish translation files use a variant of Arabic script, they need to be displayed as RTL. Currently that is inferred from language dir name after translation, and that name use the language tag, so we need to change it from 'ku' to 'ku-Arab' To test: 1) Translate to Kurdish (cd misc translator; ./translate install ku) 2) Enable Kurdish on opac/staff 3) Test staff/opac interface, they are displayed as LTR which is wrong 4) Disable Kurdish language 5) Do a cleanup (git clean -f -d) 5) Apply the patch 6) Translate again (cd misc translator; ./translate install ku-Arab) 7) Enable again 8) Test again, this time display is correct (LTR) Very easy to test Created attachment 33810 [details] [review] [SIGNED OFF] Bug 13328: Rename Kurdish translation files Kurdish translation files use a variant of Arabic script, they need to be displayed as RTL. Currently that is inferred from language dir name after translation, and that name use the language tag, so we need to change it from 'ku' to 'ku-Arab' To test: 1) Translate to Kurdish (cd misc translator; ./translate install ku) 2) Enable Kurdish on opac/staff 3) Test staff/opac interface, they are displayed as LTR which is wrong 4) Disable Kurdish language 5) Do a cleanup (git clean -f -d) 5) Apply the patch 6) Translate again (cd misc translator; ./translate install ku-Arab) 7) Enable again 8) Test again, this time display is correct (LTR) Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Easy to test. Well spotted Bernardo. Created attachment 33818 [details] [review] [PASSED QA] Bug 13328: Rename Kurdish translation files Kurdish translation files use a variant of Arabic script, they need to be displayed as RTL. Currently that is inferred from language dir name after translation, and that name use the language tag, so we need to change it from 'ku' to 'ku-Arab' To test: 1) Translate to Kurdish (cd misc translator; ./translate install ku) 2) Enable Kurdish on opac/staff 3) Test staff/opac interface, they are displayed as LTR which is wrong 4) Disable Kurdish language 5) Do a cleanup (git clean -f -d) 5) Apply the patch 6) Translate again (cd misc translator; ./translate install ku-Arab) 7) Enable again 8) Test again, this time display is correct (LTR) Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Easy to test. Well spotted Bernardo. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described. Patch pushed to master. Thanks Bernardo! |