Summary: | Subfield does not show in cataloging editor - if subfield is disabled in OPAC/enabled in Staff, via frameworks | ||
---|---|---|---|
Product: | Koha | Reporter: | Mason James <mtj> |
Component: | Cataloging | Assignee: | Galen Charlton <gmcharlt> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, dcook, irma, m.de.rooy, matted-34813, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
245b visibile
uncheck OPAC vis, for 245b 245b now hidden in editor?! fix for 13331 [Bug 13331] Subfield does not show in cataloging editor - if subfield is disabled in OPAC/enabled in Staff, via frameworks SIGNED-OFF-fix-for-13331-Bug-13331-Subfield-does-not [PASSED QA] fix for 13331 [Bug 13331] Subfield does not show in cataloging editor - if subfield is disabled in OPAC/enabled in Staff, via frameworks |
Description
Mason James
2014-11-24 17:22:11 UTC
(In reply to Mason James from comment #0) > Subfield does not show in cataloging editor - if subfield is disabled in > OPAC/enabled in Staff, via frameworks Do you have a specific example that can be tested? (In reply to David Cook from comment #1) > (In reply to Mason James from comment #0) > > Subfield does not show in cataloging editor - if subfield is disabled in > > OPAC/enabled in Staff, via frameworks > > Do you have a specific example that can be tested? hmm, any subfield will do... 1/ attempt to add a new bib in the cataloguing editor, default framewok - observe 245b subfield is visible in the editor, for tab 2 2/ uncheck the OPAC visibility for 245b, within the framework editor - then save 3/ repeat step 1/ - observe that the 245b subfield has disappeared from the cataloguing editor! Created attachment 33891 [details]
245b visibile
Created attachment 33892 [details]
uncheck OPAC vis, for 245b
Created attachment 33893 [details]
245b now hidden in editor?!
Created attachment 33928 [details] [review] fix for 13331 [Bug 13331] Subfield does not show in cataloging editor - if subfield is disabled in OPAC/enabled in Staff, via frameworks to test... 1/ attempt to add a new bib in the cataloguing editor, default framewok - observe 245b subfield is visible in the editor, for tab 2 2/ uncheck the OPAC visibility for 245b, within the framework editor - then save 3/ repeat step 1/ - observe that the 245b subfield has disappeared from the cataloguing editor! 4/ apply patch, 5/ repeat step 1/ - observe that the 245b subfield now displays correctly in the cataloguing editor note: this looks looks like a typo bug, that has been in koha for years Ahh, I follow you now. I'll have to take a look at this when I get a chance. Good catch :) i should add a bit more info about 'hidden' values, for the record if you look in the add_biblio.tt template file, you can see the logic for the values.. based on this code, it seems to me that any subfield that's 'hidden' value is <= -4 or >= 5 should be hidden in the editor, yes? --------------------------------- if ( flagged_checked ) { hidden_value='-8'; } else if ( opac_checked && ! intranet_checked && ! editor_checked && collapsed_checked ) { hidden_value='-7'; } else if ( opac_checked && intranet_checked && ! editor_checked && ! collapsed_checked) { hidden_value='-6'; } else if ( opac_checked && intranet_checked && ! editor_checked && collapsed_checked) { hidden_value='-5'; } else if ( opac_checked && ! intranet_checked && ! editor_checked && ! collapsed_checked) { hidden_value='-4'; } else if ( opac_checked && ! intranet_checked && editor_checked && collapsed_checked) { hidden_value='-3'; } else if ( opac_checked && ! intranet_checked && editor_checked && ! collapsed_checked) { hidden_value='-2'; } else if ( opac_checked && intranet_checked && editor_checked && collapsed_checked) { hidden_value='-1'; } else if ( opac_checked && intranet_checked && editor_checked && ! collapsed_checked) { hidden_value='0'; } else if ( ! opac_checked && intranet_checked && editor_checked && collapsed_checked) { hidden_value='1'; } else if ( ! opac_checked && ! intranet_checked && editor_checked && ! collapsed_checked) { hidden_value='2'; } else if ( ! opac_checked && ! intranet_checked && editor_checked && collapsed_checked) { hidden_value='3'; } else if ( ! opac_checked && intranet_checked && editor_checked && ! collapsed_checked) { hidden_value='4'; } else if ( ! opac_checked && ! intranet_checked && ! editor_checked && collapsed_checked) { hidden_value='5'; } else if ( ! opac_checked && intranet_checked && ! editor_checked && ! collapsed_checked) { hidden_value='6'; } else if ( ! opac_checked && intranet_checked && ! editor_checked && collapsed_checked) { hidden_value='7'; } else if ( ! opac_checked && ! intranet_checked && ! editor_checked && ! collapsed_checked) { hidden_value='8'; } --------------------------------- -9 => Future use -8 => Flag -7 => OPAC !Intranet !Editor Collapsed -6 => OPAC Intranet !Editor !Collapsed -5 => OPAC Intranet !Editor Collapsed -4 => OPAC !Intranet !Editor !Collapsed -3 => OPAC !Intranet Editor Collapsed -2 => OPAC !Intranet Editor !Collapsed -1 => OPAC Intranet Editor Collapsed 0 => OPAC Intranet Editor !Collapsed 1 => !OPAC Intranet Editor Collapsed 2 => !OPAC !Intranet Editor !Collapsed 3 => !OPAC !Intranet Editor Collapsed 4 => !OPAC Intranet Editor !Collapsed 5 => !OPAC !Intranet !Editor Collapsed 6 => !OPAC Intranet !Editor !Collapsed 7 => !OPAC Intranet !Editor Collapsed 8 => !OPAC !Intranet !Editor !Collapsed 9 => Future use So "<= -4 or >= 5 should be hidden in the editor" is a yep, I believe :) Created attachment 34007 [details] [review] SIGNED-OFF-fix-for-13331-Bug-13331-Subfield-does-not Followed steps for 245b (see breadcrumb in 33892) Once selecting default framework MARCStructure link, searched for 245, "Subfields" link, then "b" -> advanced. Above test plan worked. (In reply to wajasu from comment #10) > Created attachment 34007 [details] [review] [review] > SIGNED-OFF-fix-for-13331-Bug-13331-Subfield-does-not > > Followed steps for 245b (see breadcrumb in 33892) > Once selecting default framework MARCStructure link, searched for 245, > "Subfields" link, then "b" -> advanced. > > Above test plan worked. I have also tested using a biblibre sandbox and found the patch works as expected. I tested several conditions with no error. Thank you Mason! Adding a sign-off. Created attachment 34151 [details] [review] [PASSED QA] fix for 13331 [Bug 13331] Subfield does not show in cataloging editor - if subfield is disabled in OPAC/enabled in Staff, via frameworks to test... 1/ attempt to add a new bib in the cataloguing editor, default framewok - observe 245b subfield is visible in the editor, for tab 2 2/ uncheck the OPAC visibility for 245b, within the framework editor - then save 3/ repeat step 1/ - observe that the 245b subfield has disappeared from the cataloguing editor! 4/ apply patch, 5/ repeat step 1/ - observe that the 245b subfield now displays correctly in the cataloguing editor note: this looks looks like a typo bug, that has been in koha for years Signed-off-by: wajasu <matted@34813.mypacks.net> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch pushed to master. Thanks Mason! PS. try to tidy your commit messages a bit next time :-D Pushed to 3.18.x, will be in 3.18.2 (In reply to Tomás Cohen Arazi from comment #13) > Patch pushed to master. > > Thanks Mason! > > PS. try to tidy your commit messages a bit next time :-D can you show me an example of an untidy commit message from me? (In reply to Chris Cormack from comment #14) > Pushed to 3.18.x, will be in 3.18.2 Patch pushed for 3.16.8 release (In reply to Mason James from comment #15) > (In reply to Tomás Cohen Arazi from comment #13) > > Patch pushed to master. > > > > Thanks Mason! > > > > PS. try to tidy your commit messages a bit next time :-D > > can you show me an example of an untidy commit message from me? Sorry, I meant the subject! (In reply to Tomás Cohen Arazi from comment #17) > (In reply to Mason James from comment #15) > > (In reply to Tomás Cohen Arazi from comment #13) > > > Patch pushed to master. > > > > > > Thanks Mason! > > > > > > PS. try to tidy your commit messages a bit next time :-D > > > > can you show me an example of an untidy commit message from me? > > Sorry, I meant the subject! aah, yes - my mistake :0) |