Summary: | Items disappear from staff detail page when there is an on-site checkout | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Circulation | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | blocker | ||
Priority: | P5 - low | CC: | gmcharlt, jonathan.druart, kyle.m.hall, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 13332: Fix conflict between 5304 and 10850
Bug 13332: Fix conflict between 5304 and 10860 Bug 13332: Fix conflict between 5304 and 10860 [PASSED QA] Bug 13332: Fix conflict between 5304 and 10860 |
Description
Katrin Fischer
2014-11-24 21:39:21 UTC
Created attachment 33905 [details] [review] Bug 13332: Fix conflict between 5304 and 10850 These 2 bugs are in conflict. The first one always join the issue table, the second one join on this table too if the OnSiteCheckouts pref is enable. So DBI raises an error if the pref is enabled (2 joins on the same table). This patch removes the conditional join. Test plan: Go on a detail record page with items and verify that items are list and that the error no more appears in the log file. Created attachment 33906 [details] [review] Bug 13332: Fix conflict between 5304 and 10860 These 2 bugs are in conflict. The first one always join the issue table, the second one join on this table too if the OnSiteCheckouts pref is enable. So DBI raises an error if the pref is enabled (2 joins on the same table). This patch removes the conditional join. Test plan: Go on a detail record page with items and verify that items are list and that the error no more appears in the log file. Created attachment 33927 [details] [review] Bug 13332: Fix conflict between 5304 and 10860 These 2 bugs are in conflict. The first one always join the issue table, the second one join on this table too if the OnSiteCheckouts pref is enable. So DBI raises an error if the pref is enabled (2 joins on the same table). This patch removes the conditional join. Test plan: Go on a detail record page with items and verify that items are list and that the error no more appears in the log file. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Reproduced the problem, the patch fixes it, no noticeable regression found. Created attachment 33941 [details] [review] [PASSED QA] Bug 13332: Fix conflict between 5304 and 10860 These 2 bugs are in conflict. The first one always join the issue table, the second one join on this table too if the OnSiteCheckouts pref is enable. So DBI raises an error if the pref is enabled (2 joins on the same table). This patch removes the conditional join. Test plan: Go on a detail record page with items and verify that items are list and that the error no more appears in the log file. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Reproduced the problem, the patch fixes it, no noticeable regression found. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, items are visible again. Passes tests and QA script. Patch pushed to master. Thanks Jonathan! |