Summary: | Cart button doesn't open the cart | ||
---|---|---|---|
Product: | Koha | Reporter: | Liz Rea <liz> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, mtj, tomascohen, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 13339 - Cart button doesn't open the cart
[Signed-off] Bug 13339 - Cart button doesn't open the cart [PASSED QA] Bug 13339 - Cart button doesn't open the cart |
Description
Liz Rea
2014-11-26 03:52:31 UTC
Created attachment 35475 [details] [review] Bug 13339 - Cart button doesn't open the cart The link to open the cart no longer triggers the cart popup. Instead, in order to make it more usable with mobile devices, it triggers a menu which displays the count of items in the cart -- something which previously was done with a hover action (something touch-screen devices don't have). Clicking/tapping this menu item is what opens the cart window. Since the cart link is really now a menu trigger rather than just a link, it seems logical to add the small arrow which the lists link has indicating that the link triggers a menu. To test, apply the patch and view any page in a Cart-enabled OPAC. Confirm that the "caret" icon displays correctly when the cart is both empty and when it has contents. Created attachment 35635 [details] [review] [Signed-off] Bug 13339 - Cart button doesn't open the cart The link to open the cart no longer triggers the cart popup. Instead, in order to make it more usable with mobile devices, it triggers a menu which displays the count of items in the cart -- something which previously was done with a hover action (something touch-screen devices don't have). Clicking/tapping this menu item is what opens the cart window. Since the cart link is really now a menu trigger rather than just a link, it seems logical to add the small arrow which the lists link has indicating that the link triggers a menu. To test, apply the patch and view any page in a Cart-enabled OPAC. Confirm that the "caret" icon displays correctly when the cart is both empty and when it has contents. Followed test plan. Icon displays as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 35649 [details] [review] [PASSED QA] Bug 13339 - Cart button doesn't open the cart The link to open the cart no longer triggers the cart popup. Instead, in order to make it more usable with mobile devices, it triggers a menu which displays the count of items in the cart -- something which previously was done with a hover action (something touch-screen devices don't have). Clicking/tapping this menu item is what opens the cart window. Since the cart link is really now a menu trigger rather than just a link, it seems logical to add the small arrow which the lists link has indicating that the link triggers a menu. To test, apply the patch and view any page in a Cart-enabled OPAC. Confirm that the "caret" icon displays correctly when the cart is both empty and when it has contents. Followed test plan. Icon displays as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, good idea. Patch pushed to master. Thanks Owen! Pushed to 3.18.x will be in 3.18.4 (In reply to Chris Cormack from comment #5) > Pushed to 3.18.x will be in 3.18.4 Pushed to 3.16.x, will be in 3.16.8 Thanks, this is an improvement. :) |