Summary: | The type of the OpacExportOptions pref should be multiple | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | kyle, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 13346: OpacExportOptions becomes multiple
Bug 13346: OpacExportOptions becomes multiple [PASSED QA] Bug 13346: OpacExportOptions becomes multiple |
Description
Jonathan Druart
2014-11-26 15:47:04 UTC
Created attachment 33955 [details] [review] Bug 13346: OpacExportOptions becomes multiple The list of options is limited, the interface could be more ergonomic. Test plan: - verify that you are still allowed to change (add/remove) options for the OpacExportOptions pref. - At the OPAC, verify the selected options appear correctly (check the 3 pages opac-ISBDdetail.pl, opac-MARCdetail.pl and opac-detail.pl). Created attachment 34748 [details] [review] Bug 13346: OpacExportOptions becomes multiple The list of options is limited, the interface could be more ergonomic. Test plan: - verify that you are still allowed to change (add/remove) options for the OpacExportOptions pref. - At the OPAC, verify the selected options appear correctly (check the 3 pages opac-ISBDdetail.pl, opac-MARCdetail.pl and opac-detail.pl). Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> The new list is much nicer, but it adds a small regression - you can no longer change the sequence the options are displayed in. I think if someone really wanted to, they can do so via SQL, so probably not worth holding this up. (In reply to Katrin Fischer from comment #3) > The new list is much nicer, but it adds a small regression - you can no > longer change the sequence the options are displayed in. I think if someone > really wanted to, they can do so via SQL, so probably not worth holding this > up. To be fair, I did not think about that. Created attachment 34895 [details] [review] [PASSED QA] Bug 13346: OpacExportOptions becomes multiple The list of options is limited, the interface could be more ergonomic. Test plan: - verify that you are still allowed to change (add/remove) options for the OpacExportOptions pref. - At the OPAC, verify the selected options appear correctly (check the 3 pages opac-ISBDdetail.pl, opac-MARCdetail.pl and opac-detail.pl). Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> (In reply to Jonathan Druart from comment #4) > (In reply to Katrin Fischer from comment #3) > > The new list is much nicer, but it adds a small regression - you can no > > longer change the sequence the options are displayed in. I think if someone > > really wanted to, they can do so via SQL, so probably not worth holding this > > up. > > To be fair, I did not think about that. It could be accomplished with some javascript in opacuserjs if need be. Patch pushed to master. Thanks Jonathan! |