Bug 13355

Summary: System preferences tab value wrong in templates
Product: Koha Reporter: Tomás Cohen Arazi <tomascohen>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: chris, matted-34813, tomascohen
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 13355: System preferences tab value wrong in templates
[SIGNED-OFF] Bug 13355 System preferences tab value wrong in template
[SIGNED-OFF] Bug 13355: System preferences tab value wrong in templates
[PASSED QA] Bug 13355: System preferences tab value wrong in templates

Description Tomás Cohen Arazi 2014-11-27 12:10:57 UTC
To reproduce:
(1)
- Choose a tab on the sysprefs section (for example 'Enhanced Content')
- Right click on 'Enhanced Content preferences' title, and choose to 'inspect' the code
=> FAIL: you will see below the form tag something like:
<input type="hidden" name="op" value="save">
<input type="hidden" name="tab" value="">

(2)
- Do a syspref search (for example 'facet').
- Right click on one of the category titles (for example 'OPAC preferences')
=> FAIL: you will see below the form tag something like:
<input type="hidden" name="op" value="save">
<input type="hidden" name="tab" value="HASH(0x6e53050)">
Comment 1 Tomás Cohen Arazi 2014-11-27 12:17:18 UTC Comment hidden (obsolete)
Comment 2 wajasu 2014-11-27 20:54:39 UTC Comment hidden (obsolete)
Comment 3 wajasu 2014-11-27 21:19:08 UTC Comment hidden (obsolete)
Comment 4 Kyle M Hall 2014-12-05 15:08:31 UTC
Created attachment 34149 [details] [review]
[PASSED QA] Bug 13355: System preferences tab value wrong in templates

This patch fixes a bug on the system preferences tab templates.

To test:
To reproduce:
(1)
- Choose a tab on the sysprefs section (for example 'Enhanced Content')
- Right click on 'Enhanced Content preferences' title, and choose to 'inspect' the code
=> FAIL: you will see below the form tag something like:
<input type="hidden" name="op" value="save">
<input type="hidden" name="tab" value="">

(2)
- Do a syspref search (for example 'facet').
- Right click on one of the category titles (for example 'OPAC preferences')
=> FAIL: you will see below the form tag something like:
<input type="hidden" name="op" value="save">
<input type="hidden" name="tab" value="HASH(0x6e53050)">

- Apply the patch
- Repeat (1) and (2)
=> SUCCESS: you will see below the form tag something like:

<input type="hidden" name="tab" value="enhanced_content">
and
<input type="hidden" name="tab" value="opac">

respectively.
- Sign off :-D

Regards

Signed-off-by: wajasu <matted@34813.mypacks.net>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Tomás Cohen Arazi 2014-12-17 23:08:56 UTC
Patch pushed to master.
Comment 6 Chris Cormack 2014-12-18 01:13:05 UTC
Pushed to 3.18.x will be 3.18.2