Bug 13360

Summary: C4::Ris considers that hashes are ordered
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: chris, mtj, tomascohen
Version: 3.16   
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12434
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345
GIT URL: Change sponsored?: ---
Patch complexity: Small patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 13360: C4::Ris assumes that hash keys are ordered - KW
Bug 13360: C4::Ris assumes that hash keys are ordered - KW
[PASSED QA] Bug 13360: C4::Ris assumes that hash keys are ordered - KW

Description Jonathan Druart 2014-11-28 11:22:13 UTC
If you try to export a record with several 650 fields (for instance), the KW lines won't be displayed in the fields order.
Comment 1 Jonathan Druart 2014-11-28 11:26:07 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-12-28 04:57:11 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-12-28 09:56:15 UTC
Created attachment 34761 [details] [review]
[PASSED QA] Bug 13360: C4::Ris assumes that hash keys are ordered - KW

This patch only fixes the KW order.

Test plan:
1/ Choose/create a record with several 6XX (for KW), see the code source
to know which fields you can use
2/ Export this record in RIS format
3/ Verify that the KW lines are ordered following the marc record fields
order.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

We really should refactor this whole thing into Koha::RIS sometime, it's
a horrible module at the moment.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi (tcohen) 2014-12-28 23:03:56 UTC
Patch pushed to master.

Thanks Jonathan!
Comment 5 Chris Cormack 2014-12-29 21:37:57 UTC
Pushed to 3.18.x will be in 3.18.3
Comment 6 Mason James 2015-01-16 19:29:51 UTC
Pushed to 3.16.x, patch will be in 3.16.7