Summary: | C4::Ris considers that hashes are ordered | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, mtj, tomascohen |
Version: | 3.16 | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12434 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 |
||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 13360: C4::Ris assumes that hash keys are ordered - KW
Bug 13360: C4::Ris assumes that hash keys are ordered - KW [PASSED QA] Bug 13360: C4::Ris assumes that hash keys are ordered - KW |
Description
Jonathan Druart
2014-11-28 11:22:13 UTC
Created attachment 34012 [details] [review] Bug 13360: C4::Ris assumes that hash keys are ordered - KW This patch only fixes the KW order. Test plan: 1/ Choose/create a record with several 6XX (for KW), see the code source to know which fields you can use 2/ Export this record in RIS format 3/ Verify that the KW lines are ordered following the marc record fields order. Created attachment 34742 [details] [review] Bug 13360: C4::Ris assumes that hash keys are ordered - KW This patch only fixes the KW order. Test plan: 1/ Choose/create a record with several 6XX (for KW), see the code source to know which fields you can use 2/ Export this record in RIS format 3/ Verify that the KW lines are ordered following the marc record fields order. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> We really should refactor this whole thing into Koha::RIS sometime, it's a horrible module at the moment. Created attachment 34761 [details] [review] [PASSED QA] Bug 13360: C4::Ris assumes that hash keys are ordered - KW This patch only fixes the KW order. Test plan: 1/ Choose/create a record with several 6XX (for KW), see the code source to know which fields you can use 2/ Export this record in RIS format 3/ Verify that the KW lines are ordered following the marc record fields order. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> We really should refactor this whole thing into Koha::RIS sometime, it's a horrible module at the moment. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patch pushed to master. Thanks Jonathan! Pushed to 3.18.x will be in 3.18.3 Pushed to 3.16.x, patch will be in 3.16.7 |