|
Description
Rafal Kopaczka
2014-12-02 13:12:04 UTC
Created attachment 34065 [details] [review] Bug 13373 - Update Polish web installer sample data files. Part 1/2 - mandatory files. Changes: - Translated user permission and user flags. - Changed untranslated different files from en version - Deleted unnecessary files To test: - Aplly patch - Run webinstaller on empty database (drop database if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Created attachment 34066 [details] [review] Bug 13373 - Update Polish web installer sample data files. Part 2/2 - optional files. Changes: - Deleted unnecessary files - Translated description files and some values in sql files To test: - Aplly patch - Run webinstaller on empty database (drop database and create new if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) I'm not sure if splitting this patch is necessary, but squashing should be easy. Created attachment 34612 [details] [review] Bug 13373 - Update Polish web installer sample data files. Part 1/2 - mandatory files. Changes: - Translated user permission and user flags. - Changed untranslated different files from en version - Deleted unnecessary files To test: - Aplly patch - Run webinstaller on empty database (drop database if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris <chris@bigballofwax.co.nz> Created attachment 34613 [details] [review] Bug 13373 - Update Polish web installer sample data files. Part 2/2 - optional files. Changes: - Deleted unnecessary files - Translated description files and some values in sql files To test: - Aplly patch - Run webinstaller on empty database (drop database and create new if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris <chris@bigballofwax.co.nz> Comment on attachment 34612 [details] [review] Bug 13373 - Update Polish web installer sample data files. Review of attachment 34612 [details] [review]: ----------------------------------------------------------------- ::: installer/data/mysql/pl-PL/mandatory/system_preferences.sql @@ -16,5 @@ > --- with Koha; if not, write to the Free Software Foundation, Inc., > --- 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > - > -UPDATE systempreferences SET value = 'father|mother' where variable = 'borrowerRelationship'; > -UPDATE systempreferences SET value = 'Mr|Mrs|Miss|Ms' where variable = 'BorrowersTitles'; Hi Rafal, thx for updating the Polish web installer! The system_preferences.sql can be used to set some language specific defaults - you could translate father|mother and the titles using those files in the future and maybe also set some other prefs, like DateFormat. Just a hint for the future :) Hi Rafal, running the Polish (pl-PL) web installer with all sample data selected I see some SQL errors: marc21_simple_bib_frameworks.sql ERROR 1062 (23000) at line 4090: Duplicate entry 'CF-952-i' for key 'PRIMARY' parameters.sql patron_categories.sql sample_budgets.sql ERROR 1146 (42S02) at line 1: Table 'koha.aqbudget' doesn't exist sample_holidays.sql sample_itemtypes.sql sample_labels.sql ERROR 1146 (42S02) at line 2: Table 'koha.labels_templates' doesn't exist sample_notices.sql ERROR 1452 (23000) at line 1: Cannot add or update a child row: a foreign key constraint fails (`koha`.`letter`, CONSTRAINT `message_transport_type_fk` FOREIGN KEY (`message_transport_type`) REFERENCES `message_transport_types` (`message_transport_type`) ON DELETE CASCADE ON UPDATE CASCA) sample_notices_message_attributes.sql sample_notices_message_transports.sql ERROR 1452 (23000) at line 1: Cannot add or update a child row: a foreign key constraint fails (`koha`.`message_transports`, CONSTRAINT `message_transports_ibfk_3` FOREIGN KEY (`letter_module`, `letter_code`, `branchcode`) REFERENCES `letter` (`module`, `code`, `branchcode`) ON DELETE CA) sample_numberpatterns.sql stopwords.sql system_preferences.sql userflags.sql userpermissions.sql ERROR 1062 (23000) at line 1: Duplicate entry '16-execute_reports' for key 'PRIMARY' Created attachment 35398 [details] [review] Bug 13373 - Update Polish web installer sample data files. Part 1/2 - mandatory files. Changes: - Translated user permission and user flags. - Changed untranslated different files from en version - Deleted unnecessary files To test: - Aplly patch - Run webinstaller on empty database (drop database if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris <chris@bigballofwax.co.nz> Created attachment 35399 [details] [review] Bug 13373 - Update Polish web installer sample data files. Part 2/2 - optional files. Changes: - Deleted unnecessary files - Translated description files and some values in sql files To test: - Aplly patch - Run webinstaller on empty database (drop database and create new if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris <chris@bigballofwax.co.nz> Created attachment 35400 [details] [review] Bug 13373 - [QA Followup] - Update Polish web installer sample data files Fixed "Duplicate entry CF-952-i" error in marc21_simple_bib_frameworks.sql Hi Katrin, thanks for testing. I've could replicate only one issue: "ERROR 1062 (23000) at line 4090: Duplicate entry 'CF-952-i' for key 'PRIMARY'". It's fixed in followup. Other errors are from files, that are deleted in patch. It looks like you have applied only first patch. Hi Rafal, your follow-up works and you were right about the patches, signing off now :) Created attachment 35421 [details] [review] [SIGNED OFF] Bug 13373 - Update Polish web installer sample data files. Part 1/2 - mandatory files. Changes: - Translated user permission and user flags. - Changed untranslated different files from en version - Deleted unnecessary files To test: - Aplly patch - Run webinstaller on empty database (drop database if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 35422 [details] [review] [SIGNED OFF] Bug 13373 - Update Polish web installer sample data files. Part 2/2 - optional files. Changes: - Deleted unnecessary files - Translated description files and some values in sql files To test: - Aplly patch - Run webinstaller on empty database (drop database and create new if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 35423 [details] [review] [SIGNED OFF] Bug 13373 - [QA Followup] - Update Polish web installer sample data files Fixed "Duplicate entry CF-952-i" error in marc21_simple_bib_frameworks.sql Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 35424 [details] [review] [SIGNED OFF] Bug 13373 - Update Polish web installer sample data files. Part 1/2 - mandatory files. Changes: - Translated user permission and user flags. - Changed untranslated different files from en version - Deleted unnecessary files To test: - Aplly patch - Run webinstaller on empty database (drop database if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 35425 [details] [review] [SIGNED OFF] Bug 13373 - Update Polish web installer sample data files. Part 2/2 - optional files. Changes: - Deleted unnecessary files - Translated description files and some values in sql files To test: - Aplly patch - Run webinstaller on empty database (drop database and create new if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 35426 [details] [review] [SIGNED OFF] Bug 13373 - [QA Followup] - Update Polish web installer sample data files Fixed "Duplicate entry CF-952-i" error in marc21_simple_bib_frameworks.sql Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 35495 [details] [review] [PASSED QA] Bug 13373 - Update Polish web installer sample data files. Part 1/2 - mandatory files. Changes: - Translated user permission and user flags. - Changed untranslated different files from en version - Deleted unnecessary files To test: - Aplly patch - Run webinstaller on empty database (drop database if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 35496 [details] [review] [PASSED QA] Bug 13373 - Update Polish web installer sample data files. Part 2/2 - optional files. Changes: - Deleted unnecessary files - Translated description files and some values in sql files To test: - Aplly patch - Run webinstaller on empty database (drop database and create new if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 35497 [details] [review] [PASSED QA] Bug 13373 - [QA Followup] - Update Polish web installer sample data files Fixed "Duplicate entry CF-952-i" error in marc21_simple_bib_frameworks.sql Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 35498 [details] [review] [PASSED QA] Bug 13373 - Update Polish web installer sample data files. Part 1/2 - mandatory files. Changes: - Translated user permission and user flags. - Changed untranslated different files from en version - Deleted unnecessary files To test: - Aplly patch - Run webinstaller on empty database (drop database if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 35499 [details] [review] [PASSED QA] Bug 13373 - Update Polish web installer sample data files. Part 2/2 - optional files. Changes: - Deleted unnecessary files - Translated description files and some values in sql files To test: - Aplly patch - Run webinstaller on empty database (drop database and create new if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 35500 [details] [review] [PASSED QA] Bug 13373 - [QA Followup] - Update Polish web installer sample data files Fixed "Duplicate entry CF-952-i" error in marc21_simple_bib_frameworks.sql Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 35501 [details] [review] [PASSED QA] Bug 13373 - Update Polish web installer sample data files. Part 1/2 - mandatory files. Changes: - Translated user permission and user flags. - Changed untranslated different files from en version - Deleted unnecessary files To test: - Aplly patch - Run webinstaller on empty database (drop database if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 35502 [details] [review] [PASSED QA] Bug 13373 [1/2] - Update Polish web installer sample data files. Part 1/2 - mandatory files. Changes: - Translated user permission and user flags. - Changed untranslated different files from en version - Deleted unnecessary files To test: - Aplly patch - Run webinstaller on empty database (drop database if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 35503 [details] [review] [PASSED QA] Bug 13373 [2/2] - Update Polish web installer sample data files. Part 2/2 - optional files. Changes: - Deleted unnecessary files - Translated description files and some values in sql files To test: - Aplly patch - Run webinstaller on empty database (drop database and create new if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 35504 [details] [review] [PASSED QA] Bug 13373 - [QA Followup] - Update Polish web installer sample data files Fixed "Duplicate entry CF-952-i" error in marc21_simple_bib_frameworks.sql Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patches pushed to master. Thanks Rafal! Pushed to 3.18.x will be in 3.18.4 |