Bug 13386

Test Plan:
1) Apply this patch
2) Ensure you are using the default XSLT setting for the staff and opac search results and record details
3) Find or create a record with MARC tags 246
4) Perform an opac search that would show the record in the search results
5) Note the fields uses a vertical bar to separate multiple titles. Vertical bar is wrapped in span class="separator" for easy suppression/customization of separator. Change has been made to results view and detail view.
6) Repeat steps 4 and 5 for the staff interface

Outside the scope of this change, but if I had my druthers:

246 2nd indicator specifies type of other title, would be nice to display that when 1st indicator 1.  Probab;y it would go into brackets like relator terms and would be overridden by subfield i

That out of the way, works as described and will sign off momentarily

(In reply to Nick Clemens from comment #3)
> Outside the scope of this change, but if I had my druthers:
> 
> 246 2nd indicator specifies type of other title, would be nice to display
> that when 1st indicator 1.  Probab;y it would go into brackets like relator
> terms and would be overridden by subfield i
> 
> That out of the way, works as described and will sign off momentarily

I think that will be easy to add after the fact - but do agree!

Nicole

I think that sounds like a great idea, Nick. 

One thing to keep in mind is that the second indicator isn't *always* coded; occasionally it's left blank and the type of other title isn't specified. So, I suspect you'd have to tell the xslt what to do in that case. 

(In reply to Nick Clemens from comment #3)
> Outside the scope of this change, but if I had my druthers:
> 
> 246 2nd indicator specifies type of other title, would be nice to display
> that when 1st indicator 1.  Probab;y it would go into brackets like relator
> terms and would be overridden by subfield i
> 
> That out of the way, works as described and will sign off momentarily

Should this become a new issue? 

-Winona

(In reply to rgravel from comment #6)
> I think that sounds like a great idea, Nick. 
> 
> One thing to keep in mind is that the second indicator isn't *always* coded;
> occasionally it's left blank and the type of other title isn't specified.
> So, I suspect you'd have to tell the xslt what to do in that case. 
> 
> (In reply to Nick Clemens from comment #3)
> > Outside the scope of this change, but if I had my druthers:
> > 
> > 246 2nd indicator specifies type of other title, would be nice to display
> > that when 1st indicator 1.  Probab;y it would go into brackets like relator
> > terms and would be overridden by subfield i
> > 
> > That out of the way, works as described and will sign off momentarily

If it's not easy to incorporate into these changes and if Nicole thinks this is something we can tackle later, then I'd say no. 

I'm about to put in a ticket to explore a development for dynamic display of 264s, which would similarly read the second indicator and change the label; these two things seem very related, so I can add this to the ticket to see if they might be better handled together.   

(In reply to Winona Salesky from comment #7)
> Should this become a new issue? 
> 
> -Winona

I think I can add this without to much of a problem. Let me just clarify the rules:
Label should remain "Other title:" With value indicated by ind2 in brackets after title? Or Label should be generated based on value of ind2?

Also, does $i override ind2? 

Thanks!
-Winona

(In reply to rgravel from comment #8)
> If it's not easy to incorporate into these changes and if Nicole thinks this
> is something we can tackle later, then I'd say no. 
> 
> I'm about to put in a ticket to explore a development for dynamic display of
> 264s, which would similarly read the second indicator and change the label;
> these two things seem very related, so I can add this to the ticket to see
> if they might be better handled together.   
> 
> (In reply to Winona Salesky from comment #7)
> > Should this become a new issue? 
> > 
> > -Winona

Created attachment 38087 [details] [review]
[PASSED QA] Bug 13386 - Added separator to full and brief display.

This patch adds a  separator | to the full and brief displays in the staff and OPAC views.
Separator wrapped with span clas=separator |
To test:

* Search the opac
* Click the title
* Make sure the fields display properly
* Repeat for a few more titles
* Repeat in the Staff Client

http://bugs.koha-community.org/show_bug.cgi?id=13386
Signed-off-by: Nick Clemens <nick@quecheelibrary.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

(In reply to Winona Salesky from comment #9)
> I think I can add this without to much of a problem. Let me just clarify the
> rules:
> Label should remain "Other title:" With value indicated by ind2 in brackets
> after title? Or Label should be generated based on value of ind2?
> 
> Also, does $i override ind2? 
> 
> Thanks!
> -Winona
> 

Nick or Nicole, could one of you file a new bug with these ideas so they won't get lost? This is already passed QA and will probably be pushed as it is now.

Patch pushed to master.

Thanks Winona!

Great!
Thank you,
-Winona

(In reply to Tomás Cohen Arazi from comment #12)
> Patch pushed to master.
> 
> Thanks Winona!

Done- I think - please add to/edit it if need be: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14054