Summary: | sort branches alphabetically in admin/authorised_values.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | System Administration | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, gmcharlt, koha.aixmarseille, mtj, tomascohen, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 13401 - sort branches alphabetically in admin/authorised_values.pl
[Signed-off] Bug 13401 - sort branches alphabetically in admin/authorised_values.pl [PASSED QA] Bug 13401 - sort branches alphabetically in admin/authorised_values.pl |
Description
Fridolin Somers
2014-12-05 14:00:29 UTC
Created attachment 34146 [details] [review] Bug 13401 - sort branches alphabetically in admin/authorised_values.pl This patch adds a sort of branches alphabetically by name in authorised values administration, like in many other pages. Also replaces var $branch (too ambigus) by $branchcode. Test plan : - Create 2 branches : code=AAA,name=Zbranch and code=ZZZ,name=Abranch - Create a new authorized value : admin/authorised_values.pl - Look at "Libraries limitation" : => Without patch branches are sorted by code : Zbranch then Abranch => Without patch branches are sorted by name : Abranch then Zbranch - Select a branch and save - Re-edit => Check the same branch is selected Created attachment 34164 [details] [review] [Signed-off] Bug 13401 - sort branches alphabetically in admin/authorised_values.pl This patch adds a sort of branches alphabetically by name in authorised values administration, like in many other pages. Also replaces var $branch (too ambigus) by $branchcode. Test plan : - Create 2 branches : code=AAA,name=Zbranch and code=ZZZ,name=Abranch - Create a new authorized value : admin/authorised_values.pl - Look at "Libraries limitation" : => Without patch branches are sorted by code : Zbranch then Abranch => Without patch branches are sorted by name : Abranch then Zbranch - Select a branch and save - Re-edit => Check the same branch is selected Followed test plan. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 34345 [details] [review] [PASSED QA] Bug 13401 - sort branches alphabetically in admin/authorised_values.pl This patch adds a sort of branches alphabetically by name in authorised values administration, like in many other pages. Also replaces var $branch (too ambigus) by $branchcode. Test plan : - Create 2 branches : code=AAA,name=Zbranch and code=ZZZ,name=Abranch - Create a new authorized value : admin/authorised_values.pl - Look at "Libraries limitation" : => Without patch branches are sorted by code : Zbranch then Abranch => Without patch branches are sorted by name : Abranch then Zbranch - Select a branch and save - Re-edit => Check the same branch is selected Followed test plan. Patch behaves as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch pushed to master. Thanks Fridolin! Pushed to 3.18.x will be in 3.18.4 Pushed to 3.16.x, will be in 3.16.8 Pushed to 3.14, will be in 3.14.15. |