|
Description
paxed
2014-12-08 07:36:14 UTC
Created attachment 78995 [details] [review] Bug 13406 : Add styling classes to authority MARC detail display When viewing authority MARC records in the staff client (detail view), the MARC tags were not displaying with the tag_num, tag_desc, tag_ind1, tag_ind2, and desc classes, which made it impossible to add styles to these specific parts of a MARC tag. This commit adds these styles (which are the same as the classes in the bibliographic MARC detail display). To test: 1) Open the staff client, then click Authorities. 2) Search for an authority record. 3) Click on Details. 4) Examine some MARC fields. Note that the entire tag title line is in a single <div>. 5) Apply this commit. 6) Repeat steps 1-3. 7) Notice that the tag title line is now separated into several spans, each with their own classes. Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Created attachment 78996 [details] [review] Bug 13406 : Add styling classes to authority MARC detail display When viewing authority MARC records in the staff client (detail view), the MARC tags were not displaying with the tag_num, tag_desc, tag_ind1, tag_ind2, and desc classes, which made it impossible to add styles to these specific parts of a MARC tag. This commit adds these styles (which are the same as the classes in the bibliographic MARC detail display). To test: 1) Open the staff client, then click Authorities. 2) Search for an authority record. 3) Click on Details. 4) Examine some MARC fields. Note that the entire tag title line is in a single <div>. 5) Apply this commit. 6) Repeat steps 1-3. 7) Notice that the tag title line is now separated into several spans, each with their own classes. Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Created attachment 78999 [details] [review] Bug 13406 : Add styling classes to authority MARC detail display When viewing authority MARC records in the staff client (detail view), the MARC tags were not displaying with the tag_num, tag_desc, tag_ind1, tag_ind2, and desc classes, which made it impossible to add styles to these specific parts of a MARC tag. This commit adds these styles (which are the same as the classes in the bibliographic MARC detail display). To test: 1) Open the staff client, then click Authorities. 2) Search for an authority record. 3) Click on Details. 4) Examine some MARC fields. Note that the entire tag title line is in a single <div>. 5) Apply this commit. 6) Repeat steps 1-3. 7) Notice that the tag title line is now separated into several spans, each with their own classes. Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Change in the behavior, not sure it is expected: Before the patch: 040 ## - CATALOGING SOURCE After the path : 040 - CATALOGING SOURCE There is call to C4::Koha::display_marc_indicators that is no longer taken into account. I think it's possible that indicators are not always numeric - not sure if that factors in here. Just something I have seen in the wild. Created attachment 79026 [details] [review] Bug 13406: (follow-up) Add styling classes to authority MARC detail display Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Created attachment 79053 [details] [review] Bug 13406: Add styling classes to authority MARC detail display When viewing authority MARC records in the staff client (detail view), the MARC tags were not displaying with the tag_num, tag_desc, tag_ind1, tag_ind2, and desc classes, which made it impossible to add styles to these specific parts of a MARC tag. This commit adds these styles (which are the same as the classes in the bibliographic MARC detail display). To test: 1) Open the staff client, then click Authorities. 2) Search for an authority record. 3) Click on Details. 4) Examine some MARC fields. Note that the entire tag title line is in a single <div>. 5) Apply this commit. 6) Repeat steps 1-3. 7) Notice that the tag title line is now separated into several spans, each with their own classes. Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 79054 [details] [review] Bug 13406: (follow-up) Add styling classes to authority MARC detail display Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Amended patch: replace tab characters with spaces Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Great first patches Jane, congrats! Thanks for your help, Jonathan! This was fun. :-) Created attachment 79117 [details] [review] Bug 13406: (RM follow-up) Add missing filter Awesome work all! Pushed to master for 18.11 Nice little enhancement with no unexpected visible effects, simply allows end users more options for customisation. Backporting to 18.05.x series for 18.05.04, nice work Jane, welcome to the team :) Created attachment 79173 [details] [review] Bug 13406: (RM follow-up) Add missing filter Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: qwer <qwer@qwer.qwer> |