| Summary: | Remove methods which are included in the 0.36 release of PDF::Reuse | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Chris Nighswonger <cnighswonger> |
| Component: | Label/patron card printing | Assignee: | Chris Nighswonger <cnighswonger> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P3 | CC: | chris, jonathan.druart, mtj, mtompset, robin, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | Sponsored | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Patch removing duplicate methods
Bug 13407: Removing depricated code included in PDF::Reuse Bump PDF::Reuse version requirements to the latest release Bug 13406: Removing depricated code included in PDF::Reuse Bug 13407 Bumping required version of PDF::Reuse [PASSED QA] Bug 13406: Removing depricated code included in PDF::Reuse [PASSED QA] Bug 13407 Bumping required version of PDF::Reuse |
||
|
Description
Chris Nighswonger
2014-12-08 13:39:17 UTC
Created attachment 34173 [details] [review] Patch removing duplicate methods This patch should only be applied after the release of PDF::Reuse 0.36. NOTE: This depends on https://rt.cpan.org/Ticket/Display.html?id=100779 To test: 1. Upgrade PDF::Reuse to 0.35_04. [1] 2. Run Koha's non-DB dependent test suite. You should notice some non-fatal warnings about the redefinition of one or two subs in PDF::Reuse. This should not affect the functionality of the tools for the end user. 3. Verify the functionality of the related tools. 4. Apply the attached patch. 5. Re-run Koha's non-DB dependent test suite. You should note no warnings related to PDF::Reuse. 6. Re-verify the functionality of the related tools. [1] http://search.cpan.org/CPAN/authors/id/C/CN/CNIGHS/PDF-Reuse-0.35_04.tar.gz Here is a deb file for the above mentioned PDF::Reuse release which may be easier to use for testing: http://debian.koha-community.org/koha/other_files/libpdf-reuse-perl_0.35-05-1_all.deb Many thanks to Robin for taking the time to help with getting this together. Created attachment 34512 [details] [review] Bug 13407: Removing depricated code included in PDF::Reuse http://bugs.koha-community.org/show_bug.cgi?id=13407 See test plan in comment #3. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> It should be noted, I actually attempted to find the individual tests that triggered it. t/Label* t/Patron* t/Creator* if I recall correctly. Chris, shouldn't we change the minimum version of PDF::Reuse in the dependencies file? (In reply to Jonathan Druart from comment #7) > Chris, shouldn't we change the minimum version of PDF::Reuse in the > dependencies file? Good catch. Patch attached. Created attachment 34533 [details] [review] Bump PDF::Reuse version requirements to the latest release Created attachment 34609 [details] [review] Bug 13406: Removing depricated code included in PDF::Reuse 1. Upgrade PDF::Reuse to 0.35_04. [1] 2. Run Koha's non-DB dependent test suite. You should notice some non-fatal warnings about the redefinition of one or two subs in PDF::Reuse. This should not affect the functionality of the tools for the end user. 3. Verify the functionality of the related tools. 4. Apply the attached patch. 5. Re-run Koha's non-DB dependent test suite. You should note no warnings related to PDF::Reuse. 6. Re-verify the functionality of the related tools. [1] http://search.cpan.org/CPAN/authors/id/C/CN/CNIGHS/PDF-Reuse-0.35_04.tar.gz Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Chris <chris@bigballofwax.co.nz> Created attachment 34610 [details] [review] Bug 13407 Bumping required version of PDF::Reuse Signed-off-by: Chris <chris@bigballofwax.co.nz> Created attachment 34723 [details] [review] [PASSED QA] Bug 13406: Removing depricated code included in PDF::Reuse 1. Upgrade PDF::Reuse to 0.35_04. [1] 2. Run Koha's non-DB dependent test suite. You should notice some non-fatal warnings about the redefinition of one or two subs in PDF::Reuse. This should not affect the functionality of the tools for the end user. 3. Verify the functionality of the related tools. 4. Apply the attached patch. 5. Re-run Koha's non-DB dependent test suite. You should note no warnings related to PDF::Reuse. 6. Re-verify the functionality of the related tools. [1] http://search.cpan.org/CPAN/authors/id/C/CN/CNIGHS/PDF-Reuse-0.35_04.tar.gz Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Chris <chris@bigballofwax.co.nz> http://bugs.koha-community.org/show_bug.cgi?id=13407 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 34724 [details] [review] [PASSED QA] Bug 13407 Bumping required version of PDF::Reuse Signed-off-by: Chris <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> I expect to have the .deb file on the squeeze-dev pocket for pushing, otherwise we should feed the jenkins nodes by hand using CPAN. Robin? Not yet, it'll happen very soon. Hopefully today. I'm lining it up for inclusion in Debian at the same time, and so it takes a little longer to make sure I get it right. (In reply to Robin Sheat from comment #15) > Not yet, it'll happen very soon. Hopefully today. I'm lining it up for > inclusion in Debian at the same time, and so it takes a little longer to > make sure I get it right. And, done. Hopefully it'll be accepted for debian with no more changes too. Patches pushed to master. Nice one Chris! Pushed to 3.18.x will be in 3.18.3 Pushed to 3.16.x, will be in 3.16.7 |