|
Description
Kyle M Hall (khall)
2014-12-08 13:50:37 UTC
Created attachment 34174 [details] [review] Bug 13408 - Tell librarians they may continue scanning while checkouts table is loading Some librarians do not realize they can continue scanning items even if the checkouts table has not loaded. We should have Koha tell them explicitly that they may continue scanning barcodes. Test Plan: 1) Apply this patch 2) Load the checkouts table on circulation.pl, note the loading message is now Loading... you may continue scanning. 3) Load the checkouts table on moremember.pl, note the loading message is still Loading... Created attachment 34175 [details] [review] [Signed-off] Bug 13408 - Tell librarians they may continue scanning while checkouts table is loading Some librarians do not realize they can continue scanning items even if the checkouts table has not loaded. We should have Koha tell them explicitly that they may continue scanning barcodes. Test Plan: 1) Apply this patch 2) Load the checkouts table on circulation.pl, note the loading message is now Loading... you may continue scanning. 3) Load the checkouts table on moremember.pl, note the loading message is still Loading... Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 34186 [details] [review] [ALT] Bug 13408: Tell librarians they may continue scanning while checkouts table is loading Some librarians do not realize they can continue scanning items even if the checkouts table has not loaded. We should have Koha tell them explicitly that they may continue scanning barcodes. Test Plan: 1) Apply this patch 2) Load the checkouts table on circulation.pl, note the loading message is now Loading... you may continue scanning. 3) Load the checkouts table on moremember.pl, note the loading message is still Loading... Comment on attachment 34186 [details] [review] [ALT] Bug 13408: Tell librarians they may continue scanning while checkouts table is loading Kyle, why not just overwrite the existing variable? Created attachment 34232 [details] [review] [SIGNED-OFF] Bug 13408: Tell librarians they may continue scanning while checkouts table is loading Some librarians do not realize they can continue scanning items even if the checkouts table has not loaded. We should have Koha tell them explicitly that they may continue scanning barcodes. Test Plan: 1) Apply this patch 2) Load the checkouts table on circulation.pl, note the loading message is now Loading... you may continue scanning. 3) Load the checkouts table on moremember.pl, note the loading message is still Loading... Signed-off-by: Owen Leonard <oleonard@myacpl.org> This one works too! Kyle, is there a chance to get or signoff on this patch? your* Created attachment 34911 [details] [review] [PASSED QA] Bug 13408: Tell librarians they may continue scanning while checkouts table is loading Some librarians do not realize they can continue scanning items even if the checkouts table has not loaded. We should have Koha tell them explicitly that they may continue scanning barcodes. Test Plan: 1) Apply this patch 2) Load the checkouts table on circulation.pl, note the loading message is now Loading... you may continue scanning. 3) Load the checkouts table on moremember.pl, note the loading message is still Loading... Signed-off-by: Owen Leonard <oleonard@myacpl.org> This one works too! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch pushed to master. Thanks Jonathan! Pushed to 3.18.x will be in 3.18.3 Pushed to 3.16.x, patch will be in 3.16.7 We find the pop-up message that appears every time a barcode is scanned is distracting and hard on the eyes for staff at a busy checkout. Would prefer the option in system preferences to turn it off. I expect after staff have seen it a few times they may permanently get the message and it would not be needed any more. Also staff find checkout significantly slower from 3.14 to 3.20 - this may not be the only factor, but I would prefer to be able to turn off any features that might affect response time of system and of staff. (In reply to Agnes Rivers-Moore from comment #12) > We find the pop-up message that appears every time a barcode is scanned is > distracting and hard on the eyes for staff at a busy checkout. > Would prefer the option in system preferences to turn it off. > I expect after staff have seen it a few times they may permanently get the > message and it would not be needed any more. > Also staff find checkout significantly slower from 3.14 to 3.20 - this may > not be the only factor, but I would prefer to be able to turn off any > features that might affect response time of system and of staff. Hi Agnes Once a bug is pushed, the best thing to do is to open a new bug, and link to this one. Or your comment will be missed. (This is marked pushed to stable, so it wont be showing up on anyone's lists to check) Hope this make sense. I do agree, the ajax circ stuff is slower, unless you have a borrower with a large amount of existing checkouts. I think there may be some bugs around the speed issue already. |