Description
Jonathan Druart
2014-12-09 16:09:19 UTC
Created attachment 34241 [details] [review] Bug 13419: Add server-side processing for lists This patch adds DataTables using a server-side processing to display lists (virtual shelves). Test plan: 1/ Go on virtualshelves/shelves.p 2/ Play with the table functions (sort, filter, pagination, etc.) 3/ Go with the Public lists tab and verify the table is correctly filtered. Created attachment 34242 [details] [review] Bug 13419: Add filters on the list table Created attachment 34243 [details] [review] Bug 13419: Add tests Test plan: prove t/db_dependent/Utils/Datatables_Virtualshelves.t should return green The filter behaves as follows: Edit / change 'List name' Result: List is filtered: OK Edit /change 'Author': Result: List is filtered: OK Change selection in drop box 'Sort by' Result: No change in list. You have to change 'List name' or 'Author' to trigger filtering. - This is confusing. Created attachment 34504 [details] [review] [Signed-off] Bug 13421: Add the creation time for virtual shelves Test plan: 1/ Execute the updatedb entry 2/ Create a list 3/ Go on the shelve list and confirm that the creation and last modification time are now displayed. 4/ Confirm that you are able to sort the list by creation/modification time. Applied on top of 13419 (rebased updatedatabase.pl) Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Comment on attachment 34504 [details] [review] [Signed-off] Bug 13421: Add the creation time for virtual shelves Sorry, attached to wrong bug (In reply to Marc Véron from comment #4) > Change selection in drop box 'Sort by' > Result: No change in list. You have to change 'List name' or 'Author' to > trigger filtering. - This is confusing. Looks good here. Did you see the "processing" message? Created attachment 34514 [details] [review] [Signed-off] Bug 13419: Add server-side processing for lists This patch adds DataTables using a server-side processing to display lists (virtual shelves). Test plan: 1/ Go on virtualshelves/shelves.p 2/ Play with the table functions (sort, filter, pagination, etc.) 3/ Go with the Public lists tab and verify the table is correctly filtered. Tested together with patch #2, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 34515 [details] [review] [Signed-off] Bug 13419: Add filters on the list table Tested together with patch #1, works as expected Signed-off-by: Marc Véron <veron@veron.ch> For patch #3 "Add tests" I get errors # Failed test 'There should be 12 public shelves in total' # at t/db_dependent/Utils/Datatables_Virtualshelves.t line 199. # got: '15' # expected: '12' # Failed test 'There should be 12 private shelves' # at t/db_dependent/Utils/Datatables_Virtualshelves.t line 202. # got: '15' # expected: '12' # Failed test 'There should be 12 public shelves in total' # at t/db_dependent/Utils/Datatables_Virtualshelves.t line 214. # got: '15' # expected: '12' # Failed test 'There should be 12 public shelves in total' # at t/db_dependent/Utils/Datatables_Virtualshelves.t line 230. # got: '15' # expected: '12' # Looks like you failed 4 tests of 13. However if I remove all public lists, it passes OK Created attachment 34516 [details] [review] Bug 13419: (follow-up) Add tests - remove existing shelves (In reply to Marc Véron from comment #10) > For patch #3 "Add tests" I get errors Good catch Marc, thanks for testing! Created attachment 34517 [details] [review] [Signed-off] Bug 13419: Add tests Test plan: prove t/db_dependent/Utils/Datatables_Virtualshelves.t should return green Tested together with follow-up, works as expected Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 34518 [details] [review] [Signed-off] Bug 13419: (follow-up) Add tests - remove existing shelves Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 34577 [details] [review] [PASSED QA] Bug 13419: Add server-side processing for lists This patch adds DataTables using a server-side processing to display lists (virtual shelves). Test plan: 1/ Go on virtualshelves/shelves.p 2/ Play with the table functions (sort, filter, pagination, etc.) 3/ Go with the Public lists tab and verify the table is correctly filtered. Tested together with patch #2, works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 34578 [details] [review] [PASSED QA] Bug 13419: Add filters on the list table Tested together with patch #1, works as expected Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 34579 [details] [review] [PASSED QA] Bug 13419: Add tests Test plan: prove t/db_dependent/Utils/Datatables_Virtualshelves.t should return green Tested together with follow-up, works as expected Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 34580 [details] [review] [PASSED QA] Bug 13419: (follow-up) Add tests - remove existing shelves Works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 38188 [details] [review] Bug 13419: Add server-side processing for lists This patch adds DataTables using a server-side processing to display lists (virtual shelves). Test plan: 1/ Go on virtualshelves/shelves.p 2/ Play with the table functions (sort, filter, pagination, etc.) 3/ Go with the Public lists tab and verify the table is correctly filtered. Tested together with patch #2, works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 38189 [details] [review] Bug 13419: Add filters on the list table Tested together with patch #1, works as expected Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 38190 [details] [review] Bug 13419: Add tests Test plan: prove t/db_dependent/Utils/Datatables_Virtualshelves.t should return green Tested together with follow-up, works as expected Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 38191 [details] [review] Bug 13419: (follow-up) Add tests - remove existing shelves Works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patches rebased. Created attachment 38193 [details] [review] Bug 13419: Add server-side processing for lists This patch adds DataTables using a server-side processing to display lists (virtual shelves). Test plan: 1/ Go on virtualshelves/shelves.p 2/ Play with the table functions (sort, filter, pagination, etc.) 3/ Go with the Public lists tab and verify the table is correctly filtered. Tested together with patch #2, works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 38194 [details] [review] Bug 13419: Add filters on the list table Tested together with patch #1, works as expected Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 38195 [details] [review] Bug 13419: Add tests Test plan: prove t/db_dependent/Utils/Datatables_Virtualshelves.t should return green Tested together with follow-up, works as expected Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 38196 [details] [review] Bug 13419: (follow-up) Add tests - remove existing shelves Works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 38347 [details] [review] Bug 13419: (follow-up) fix call to set_userenv Created attachment 38355 [details] [review] Bug 13419: (QA followup) remove useless warnings Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Patches pushed to master. Thanks Jonathan! |