Summary: | Add the creation time for virtual shelves | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Lists | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | kyle, m.de.rooy, tomascohen, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 13419 | ||
Bug Blocks: | |||
Attachments: |
Bug 13421: Add the creation time for virtual shelves
[Signed-off] Bug 13421: Add the creation time for virtual shelves [PASSED QA] Bug 13421: Add the creation time for virtual shelves Bug 13421 - Change creation_time to created_on Bug 13421: Add the creation time for virtual shelves Bug 13421 - Change creation_time to created_on Bug 13421: (RM followup) DBIx updates |
Description
Jonathan Druart
2014-12-09 16:17:34 UTC
Created attachment 34244 [details] [review] Bug 13421: Add the creation time for virtual shelves Test plan: 1/ Execute the updatedb entry 2/ Create a list 3/ Go on the shelve list and confirm that the creation and last modification time are now displayed. 4/ Confirm that you are able to sort the list by creation/modification time. Wanted to test, got: Applying: Bug 13421: Add the creation time for virtual shelves fatal: sha1 information is lacking or useless (C4/Utils/DataTables/VirtualShelves.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Marc, did you apply the dependency? Created attachment 34505 [details] [review] [Signed-off] Bug 13421: Add the creation time for virtual shelves Test plan: 1/ Execute the updatedb entry 2/ Create a list 3/ Go on the shelve list and confirm that the creation and last modification time are now displayed. 4/ Confirm that you are able to sort the list by creation/modification time. Applied on top of 13419 (rebased updatedatabase.pl) Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 34581 [details] [review] [PASSED QA] Bug 13421: Add the creation time for virtual shelves Test plan: 1/ Execute the updatedb entry 2/ Create a list 3/ Go on the shelve list and confirm that the creation and last modification time are now displayed. 4/ Confirm that you are able to sort the list by creation/modification time. Applied on top of 13419 (rebased updatedatabase.pl) Works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 34583 [details] [review] Bug 13421 - Change creation_time to created_on I think we need to standardize our timestamp columns in Koha. I think this would be as good a place to start as any. I would suggest we use created_on for creation timestamps, and updated_on for last updated timestamps, if you have no objections. This is the naming convention I used for the accounts rewrite. I will also bring the issue up at the next channel meeting. (In reply to Kyle M Hall from comment #7) > I think we need to standardize our timestamp columns in Koha. I think this > would be as good a place to start as any. I would suggest we use created_on > for creation timestamps, and updated_on for last updated timestamps, if you > have no objections. This is the naming convention I used for the accounts > rewrite. I will also bring the issue up at the next channel meeting. What did this channel meeting bring up? Please rebase. Created attachment 38716 [details] [review] Bug 13421: Add the creation time for virtual shelves Test plan: 1/ Execute the updatedb entry 2/ Create a list 3/ Go on the shelve list and confirm that the creation and last modification time are now displayed. 4/ Confirm that you are able to sort the list by creation/modification time. Applied on top of 13419 (rebased updatedatabase.pl) Works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 38717 [details] [review] Bug 13421 - Change creation_time to created_on Patches pushed to master. Thanks Jonathan! Created attachment 39185 [details] [review] Bug 13421: (RM followup) DBIx updates Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> |