Summary: | Fix facet deletion | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Searching | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | chris, mtj, tomascohen |
Version: | 3.18 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 13425 | ||
Bug Blocks: | |||
Attachments: |
Bug 13428: Fix regression on deleting facets
Bug 13428: Fix regression on deleting facets [PASSED QA] Bug 13428: Fix regression on deleting facets |
Description
Jonathan Druart
2014-12-10 09:00:16 UTC
Created attachment 34274 [details] [review] Bug 13428: Fix regression on deleting facets Test plan: Search for something click on a facet with diacritic click on another facet remove the facet with diacritic Patch for 3.16.x, 3.18.x and master. The intranet does not need this change (already done). Created attachment 34313 [details] [review] Bug 13428: Fix regression on deleting facets Test plan: Search for something click on a facet with diacritic click on another facet remove the facet with diacritic Signed-off-by: Mason James <mtj@kohaaloha.com> > Signed-off-by: Mason James <mtj@kohaaloha.com>
this tested OK for me on 3.16, 3.18 and master branches
(In reply to Mason James from comment #4) > > Signed-off-by: Mason James <mtj@kohaaloha.com> > > this tested OK for me on 3.16, 3.18 and master branches tested OK on prog and BS opac themes, for 3.16 Created attachment 34339 [details] [review] [PASSED QA] Bug 13428: Fix regression on deleting facets Test plan: Search for something click on a facet with diacritic click on another facet remove the facet with diacritic Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch pushed to master. Thanks Jonathan! Pushed to 3.18.x (no string changes) will be in 3.18.2 This should not have been pushed before bug 13425, because now the facets deletion is broken :) It should be pushed to 3.16.x, the patch applies cleanly. ping Mason :) (In reply to Jonathan Druart from comment #9) > This should not have been pushed before bug 13425, because now the facets > deletion is broken :) Yep 13425 opac changes are pushed to master, 3.18.x and 3.16.x and this only changes the opac, so needed to be pushed. > > It should be pushed to 3.16.x, the patch applies cleanly. > > ping Mason :) So yep just to 3.16.x now (In reply to Jonathan Druart from comment #9) > This should not have been pushed before bug 13425, because now the facets > deletion is broken :) > > It should be pushed to 3.16.x, the patch applies cleanly. > > ping Mason :) Pushed to 3.16.x, patch will be in 3.16.6 |