| Summary: | 586 XSLT improvements | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
| Component: | Templates | Assignee: | Winona Salesky <wsalesky> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | gwilliams, nick, nicole, rgravel, tomascohen, wsalesky |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 10344 | ||
| Attachments: |
Bug 13434 - RDA: 586 field changes in XSLT
[SIGNED OFF] Updated display for 586 in XSLT [PASSED QA] Updated display for 586 in XSLT [PASSED QA] Bug 13434 - Updated display for 586 in XSLT |
||
|
Description
Nicole C. Engard
2014-12-10 21:27:00 UTC
Created attachment 36806 [details] [review] Bug 13434 - RDA: 586 field changes in XSLT Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac search results and record details 3) Find or create a record with MARC tags 586 4) Perform an opac search that would show the record in the search results 5) Note the fields uses a vertical bar to separate multiple titles. Vertical bar is wrapped in span class="separator" for easy suppression/customization of separator. 6) Repeat steps 4 and 5 for the staff interface Created attachment 37592 [details] [review] [SIGNED OFF] Updated display for 586 in XSLT http://bugs.koha-community.org/show_bug.cgi?id=13434 Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Separation and display look good so signing off, but I have some questions that I am leaving for QA: 1 - Before this patch the awards displayed in the description tab only on staff-client, and both in detail view and description tab on opac. I am thinking if we are going to display on the details page we should remove from description tab on both staff/opac - maybe out of scope. 2 - indicator 1 is supposed to control generation of display content "Awards:" (display if blank, dont if =8) and it does if all =8, but with multiple fields and a mix of =8 or =# you always get the "Awards:" I don't know if it would be worth splitting them into two display sections based on the indicator or if it isn't a big deal (In reply to Winona Salesky from comment #2) > Test Plan: > 1) Apply this patch > 2) Ensure you are using the default XSLT setting for the staff and opac > search results and record details > 3) Find or create a record with MARC tags 586 > 4) Perform an opac search that would show the record in the search results > 5) Note the fields uses a vertical bar to separate multiple titles. Vertical > bar is wrapped in span class="separator" for easy suppression/customization > of separator. > 6) Repeat steps 4 and 5 for the staff interface (In reply to Nick Clemens from comment #4) > Separation and display look good so signing off, but I have some questions > that I am leaving for QA: > > 1 - Before this patch the awards displayed in the description tab only on > staff-client, and both in detail view and description tab on opac. I am > thinking if we are going to display on the details page we should remove > from description tab on both staff/opac - maybe out of scope. We have the summary in the title notes tab and above the holdings table and the table of contents as well. I think it's okay to leave and if you want to hide it from title notes you can do so using the system preference just for that. > > 2 - indicator 1 is supposed to control generation of display content > "Awards:" (display if blank, dont if =8) and it does if all =8, but with > multiple fields and a mix of =8 or =# you always get the "Awards:" I don't > know if it would be worth splitting them into two display sections based on > the indicator or if it isn't a big deal This one I'm not sure about. I think we should follow MARC rules - but lots of times libraries don't follow MARC rules :) Regarding 1: That sounds right to me, Nick. The redundancy of the contents and summary notes, for instance, drives me a little crazy personally, and so anything to avoid that appeals to me! I am in favor of leaving it only in the details and not in the notes tab. Regarding 2: I'm no expert on display constants, but I think these are for card/shelf-list printing, so I don't think that distinguishing ## from #8 is necessary, as they are all awards and the cataloger cannot supply a different label anyway. (In reply to Nick Clemens from comment #4) > Separation and display look good so signing off, but I have some questions > that I am leaving for QA: > > 1 - Before this patch the awards displayed in the description tab only on > staff-client, and both in detail view and description tab on opac. I am > thinking if we are going to display on the details page we should remove > from description tab on both staff/opac - maybe out of scope. > > 2 - indicator 1 is supposed to control generation of display content > "Awards:" (display if blank, dont if =8) and it does if all =8, but with > multiple fields and a mix of =8 or =# you always get the "Awards:" I don't > know if it would be worth splitting them into two display sections based on > the indicator or if it isn't a big deal Created attachment 38086 [details] [review] [PASSED QA] Updated display for 586 in XSLT http://bugs.koha-community.org/show_bug.cgi?id=13434 Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 38088 [details] [review] [PASSED QA] Bug 13434 - Updated display for 586 in XSLT http://bugs.koha-community.org/show_bug.cgi?id=13434 Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch pushed to master. Thanks Winona! And congrats for your patch pushed! Great news! Thanks, -Winona (In reply to Tomás Cohen Arazi from comment #9) > Patch pushed to master. > > Thanks Winona! And congrats for your patch pushed! |