Summary: | Holidays.t assumes default data | ||
---|---|---|---|
Product: | Koha | Reporter: | Mark Tompsett <mtompset> |
Component: | Test Suite | Assignee: | Mark Tompsett <mtompset> |
Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 13451: Holidays.t assumes default data
[SIGNED OFF] Bug 13451: Holidays.t assumes default data [PASSED QA] Bug 13451: Holidays.t assumes default data |
Description
Mark Tompsett
2014-12-12 16:30:15 UTC
Created attachment 34359 [details] [review] Bug 13451: Holidays.t assumes default data This patch removes that assumption by expressly setting data to be default. TEST PLAN --------- 1) Ensure that branch code is NOT 'MPL' in the repeatable_holidays table in your database. 2) Ensure that branch codes 'MPL' and 'CPL' do not exist in the branches table in your database. 3) prove t/db_dependent/Holidays.t -- this should bomb horribly. 4) Apply patch 5) prove t/db_dependent/Holidays.t -- all tests should succeed. 6) run koha qa tests Created attachment 34377 [details] [review] [SIGNED OFF] Bug 13451: Holidays.t assumes default data This patch removes that assumption by expressly setting data to be default. TEST PLAN --------- 1) Ensure that branch code is NOT 'MPL' in the repeatable_holidays table in your database. 2) Ensure that branch codes 'MPL' and 'CPL' do not exist in the branches table in your database. 3) prove t/db_dependent/Holidays.t -- this should bomb horribly. 4) Apply patch 5) prove t/db_dependent/Holidays.t -- all tests should succeed. 6) run koha qa tests Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Created attachment 34379 [details] [review] [PASSED QA] Bug 13451: Holidays.t assumes default data This patch removes that assumption by expressly setting data to be default. TEST PLAN --------- 1) Ensure that branch code is NOT 'MPL' in the repeatable_holidays table in your database. 2) Ensure that branch codes 'MPL' and 'CPL' do not exist in the branches table in your database. 3) prove t/db_dependent/Holidays.t -- this should bomb horribly. 4) Apply patch 5) prove t/db_dependent/Holidays.t -- all tests should succeed. 6) run koha qa tests Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tests pass without holidays in the calendar. Patch pushed to master. Thanks Mark! No string changes, pushed to 3.18.x will be in 3.18.2 |