Summary: | Koha.t daily quote tests assume sample data | ||
---|---|---|---|
Product: | Koha | Reporter: | Mark Tompsett <mtompset> |
Component: | Test Suite | Assignee: | Mark Tompsett <mtompset> |
Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, mtj, tomascohen, veron |
Version: | 3.16 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 13453: Koha.t daily quote tests assume sample data
Bug 13453: Koha.t daily quote tests assume sample data [PASSED QA] Bug 13453: Koha.t daily quote tests assume sample data |
Description
Mark Tompsett
2014-12-12 17:20:10 UTC
Created attachment 34360 [details] [review] Bug 13453: Koha.t daily quote tests assume sample data By adding quotes 3 and 25 from the sample data, this test can pass without having the sample quote data loaded. TEST PLAN --------- 1) Ensure there is no quote id=3 or that it is NOT Abraham Lincoln. 2) prove t/db_dependent/Koha.t -- this should fail the daily quote test. 3) apply patch 4) prove t/db_dependent/Koha.t -- this should fail the daily quote test. 5) run koha qa test tools Created attachment 34606 [details] [review] Bug 13453: Koha.t daily quote tests assume sample data By adding quotes 3 and 25 from the sample data, this test can pass without having the sample quote data loaded. TEST PLAN --------- 1) Ensure there is no quote id=3 or that it is NOT Abraham Lincoln. 2) prove t/db_dependent/Koha.t -- this should fail the daily quote test. 3) apply patch 4) prove t/db_dependent/Koha.t -- this should *NOT* fail the daily quote test. 5) run koha qa test tools Followed test plan 1)-4). Without patch, daily quote test failed. With patch, test passed OK. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 34698 [details] [review] [PASSED QA] Bug 13453: Koha.t daily quote tests assume sample data By adding quotes 3 and 25 from the sample data, this test can pass without having the sample quote data loaded. TEST PLAN --------- 1) Ensure there is no quote id=3 or that it is NOT Abraham Lincoln. 2) prove t/db_dependent/Koha.t -- this should fail the daily quote test. 3) apply patch 4) prove t/db_dependent/Koha.t -- this should *NOT* fail the daily quote test. 5) run koha qa test tools Followed test plan 1)-4). Without patch, daily quote test failed. With patch, test passed OK. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Works as described, leaves actual data unchanged. Patch pushed to master. Thanks Mark! Pushed to 3.18.x will be in 3.18.3 Pushed to 3.16.x, patch will be in 3.16.7 |