| Summary: | Members/AddEnrolmentFeeIfNeeded.t requires sample data | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Mark Tompsett <mtompset> |
| Component: | Test Suite | Assignee: | Mark Tompsett <mtompset> |
| Status: | RESOLVED DUPLICATE | QA Contact: | Galen Charlton <gmcharlt> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | jonathan.druart, magnus |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 13455: Members/AddEnrolmentFeeIfNeeded.t requires sample data
Bug 13455: Members/AddEnrolmentFeeIfNeeded.t requires sample data |
||
|
Description
Mark Tompsett
2014-12-12 20:40:06 UTC
Created attachment 34370 [details] [review] Bug 13455: Members/AddEnrolmentFeeIfNeeded.t requires sample data TEST PLAN --------- 1) Make sure there are no 'J', 'K', nor 'YA' patron category codes. 2) Make sure there are no 'CPL' nor 'MPL' branch codes. 3) prove t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t -- dies horribly 4) apply patch 5) prove t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t -- passes 6) Run koha qa test tools Created attachment 36008 [details] [review] Bug 13455: Members/AddEnrolmentFeeIfNeeded.t requires sample data TEST PLAN --------- 1) Make sure there are no 'J', 'K', nor 'YA' patron category codes. 2) Make sure there are no 'CPL' nor 'MPL' branch codes. 3) prove t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t -- dies horribly 4) apply patch 5) prove t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t -- passes 6) Run koha qa test tools Signed-off-by: Magnus Enger <magnus@enger.priv.no> For me, the tests fail because I have a Norweian setup with different categories etc. After applying the patch the tests pass. I still completely disagree with this kind of patch, see my comments on bug 13457. Moving this to "In Discussion". (In reply to Jonathan Druart from comment #3) > I still completely disagree with this kind of patch, see my comments on bug > 13457. Have we settled on assuming the sample data is available? (In reply to Katrin Fischer from comment #5) > (In reply to Jonathan Druart from comment #3) > > I still completely disagree with this kind of patch, see my comments on bug > > 13457. > > Have we settled on assuming the sample data is available? use TestBuilder. |