| Summary: | overdue notice lists all checked out books | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Yuval Hager <yhager> | 
| Component: | Notices | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> | 
| Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> | 
| Severity: | major | ||
| Priority: | P5 - low | CC: | chris, jonathan.druart, martin.renvoize, mtj, tomascohen | 
| Version: | 3.18 | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 | 
| Patch complexity: | --- | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Bug Depends on: | 12529 | ||
| Bug Blocks: | |||
| Attachments: | 
              BUG 13468: Overdue notice lists all checked out books
               BUG 13468: Overdue notice lists all checked out books BUG 13468: Overdue notice lists all checked out books  | 
      ||
| 
 
        
          Description
        
        
          Yuval Hager
        
        
        
        
          2014-12-15 21:13:30 UTC
        
       
    I Yuval, can you tell us a bit about your setup? How is the overdues script run in your installation? The script has several options that can be used, so knowing what happens on your system might help to get this fixed. We're seeing this too now... /usr/share/koha/bin/cronjobs/overdue_notices.pl -t A quick look t the code, -t is 'triggered', and the last bug to touch that was Bug 12529. (In reply to Martin Renvoize from comment #2) Our setting for 'OverduenoticeCalendar' was set to ignore if that helps (In reply to Martin Renvoize from comment #3) > (In reply to Martin Renvoize from comment #2) > Our setting for 'OverduenoticeCalendar' was set to ignore if that helps Can you bisect it until you find the commit for sure. Otherwise it'll have to wait for a while until I have any time to look at it. Created attachment 34466 [details] [review] BUG 13468: Overdue notice lists all checked out books This patch should fix the issue when running under 'triggered' mode To test: 1) Run overdue_notices.pl -t -n [to output notices to command line] 2) Note that the notices output, list ALL checked out items 3) Apply Patch 4) Run again 5) Note the difference Sorry Chris, you beat me to this one. I believe this patch does the business... My fault for missing it during QA of your patch.. I'm pretty sure it's that Holidays patch that exposed the problem. (In reply to Katrin Fischer from comment #1) > I Yuval, > > can you tell us a bit about your setup? How is the overdues script run in > your installation? The script has several options that can be used, so > knowing what happens on your system might help to get this fixed. This has probably been resolved, but I don't want to leave your question unanswered. I use the standard debian cron runs: koha-foreach --enabled --email /usr/share/koha/bin/cronjobs/overdue_notices.pl -t Thanks for the quick resolution! Created attachment 34473 [details] [review] BUG 13468: Overdue notice lists all checked out books This patch should fix the issue when running under 'triggered' mode To test: 1) Run overdue_notices.pl -t -n [to output notices to command line] 2) Note that the notices output, list ALL checked out items 3) Apply Patch 4) Run again 5) Note the difference Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Created attachment 34479 [details] [review] BUG 13468: Overdue notice lists all checked out books This patch should fix the issue when running under 'triggered' mode To test: 1) Run overdue_notices.pl -t -n [to output notices to command line] 2) Note that the notices output, list ALL checked out items 3) Apply Patch 4) Run again 5) Note the difference Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: remove space changes. Patch pushed to master. Thanks Martin! No string changes, pushed to 3.18.x will be in 3.18.2 (In reply to Chris Cormack from comment #11) > No string changes, pushed to 3.18.x will be in 3.18.2 skipping patch for 3.16.x  |