Bug 13487

Summary: DataTables pagination needs some fixes
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: TemplatesAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: chris, fridolin.somers, katrin.fischer, tomascohen
Version: master   
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13459
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13744
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12985
Change sponsored?: --- Patch complexity: Small patch
Who signed the patch off: Text to go in the release notes:
Version(s) released in:
Bug Depends on: 11425, 12986    
Bug Blocks:    
Attachments: Bug 13487: DT pagination contains '...' for the full_numbers form
Bug 13487: Fix pagination for basketgroup
Bug 13487: Fix pagination for the item search
Bug 13487: DT pagination contains '...' for the full_numbers form
Bug 13487: Fix pagination for basketgroup
Bug 13487: Fix pagination for the item search
[PASSED QA] Bug 13487: DT pagination contains '...' for the full_numbers form
[PASSED QA] Bug 13487: Fix pagination for basketgroup
[PASSED QA] Bug 13487: Fix pagination for the item search

Description Jonathan Druart 2014-12-22 09:50:20 UTC
On acqui/basketgroup.pl and catalogue/itemsearch.pl, the sPaginationType DT parameter is not explicitly defined. This broken the pagination display.

Moreover, since the DT upgrade (bug 12986), the full_numbers pagination adds a span (containing '...'). It is not managed by the css file and is put at the end of the page numbers ( "1 2 3 4 5 20 NEXT LAST ...", we expect "1 2 3 4 5 ... 20 NEXT LAST").
Comment 1 Jonathan Druart 2014-12-22 09:58:26 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2014-12-22 09:58:29 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-12-22 09:58:33 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2014-12-22 09:59:24 UTC
(In reply to Jonathan Druart from comment #1)
> Created attachment 34626 [details] [review] [review]
> Bug 13487: DT pagination contains '...' for the full_numbers form

This is certainly not the best way to fix that. Feel free to suggest something else.
Comment 5 Jonathan Druart 2014-12-22 10:00:09 UTC
Let me know if you found other pagination problems.
Comment 6 Chris Cormack 2014-12-26 19:46:18 UTC Comment hidden (obsolete)
Comment 7 Chris Cormack 2014-12-26 19:46:33 UTC Comment hidden (obsolete)
Comment 8 Chris Cormack 2014-12-26 19:46:55 UTC Comment hidden (obsolete)
Comment 9 Katrin Fischer 2014-12-27 11:55:06 UTC
Created attachment 34703 [details] [review]
[PASSED QA] Bug 13487: DT pagination contains '...' for the full_numbers form

Since the DT upgrade (bug 12986), the full_numbers pagination adds a
span (containing '...'). It is not managed by the css file and is put at
the end of the page numbers ( "1 2 3 4 5 20 NEXT LAST ...", we expect "1
2 3 4 5 ... 20 NEXT LAST").

Test plan:
1/ Go on the member search and launch a search which will return more than
7 pages
2/ Without this patch, the '...' span is put at the end of the
pagination bar.
3/ With the patch it should be better placed.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 10 Katrin Fischer 2014-12-27 11:55:08 UTC
Created attachment 34704 [details] [review]
[PASSED QA] Bug 13487: Fix pagination for basketgroup

Test plan:
Go on the acqui/basketgroup.pl page and verify that the pagination
button (First, Prev, Next, Last) is now correctly styled.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 11 Katrin Fischer 2014-12-27 11:55:11 UTC
Created attachment 34705 [details] [review]
[PASSED QA] Bug 13487: Fix pagination for the item search

Test plan:
Go on the catalogue/itemsearch.pl page and verify that the
pagination button (First, Prev, PAGES, Next, Last) is now correctly styled.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 12 Tomás Cohen Arazi 2015-01-07 23:44:14 UTC
Patches pushed to master.

Thanks Jonathan!
Comment 13 Chris Cormack 2015-01-11 07:59:50 UTC
Pushed to 3.18.x will be in 3.18.3